[GitHub] [arrow] pitrou commented on a change in pull request #12605: ARROW-15911: [C++] Minor CMake fixes for MacOS/XCode

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #12605:
URL: https://github.com/apache/arrow/pull/12605#discussion_r824048731



##########
File path: cpp/CMakeLists.txt
##########
@@ -47,6 +47,10 @@ if(POLICY CMP0074)
   cmake_policy(SET CMP0074 NEW)
 endif()
 
+if(POLICY CMP0114)
+  cmake_policy(SET CMP0114 NEW)

Review comment:
       Would you mind adding a comment explaining why this is necessary? So that future readers are not confused by this.

##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1844,10 +1844,14 @@ macro(build_gtest)
   set(GTEST_VENDORED TRUE)
   set(GTEST_CMAKE_CXX_FLAGS ${EP_CXX_FLAGS})
 
-  if(CMAKE_BUILD_TYPE MATCHES DEBUG)
-    set(CMAKE_GTEST_DEBUG_EXTENSION "d")
+  if(NOT CMAKE_GENERATOR STREQUAL Xcode)
+    if(CMAKE_BUILD_TYPE MATCHES DEBUG)
+      set(CMAKE_GTEST_DEBUG_EXTENSION "d")
+    else()
+      set(CMAKE_GTEST_DEBUG_EXTENSION "")
+    endif()
   else()
-    set(CMAKE_GTEST_DEBUG_EXTENSION "")
+    set(CMAKE_GTEST_DEBUG_EXTENSION "d")

Review comment:
       I don't understand, why is it always "d" for XCode?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org