You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "jeanvetorello (via GitHub)" <gi...@apache.org> on 2025/09/20 01:59:34 UTC
[PR] git commit -m "KVM: skip mountpoint check for RBD storage pools" [cloudstack]
jeanvetorello opened a new pull request, #11690:
URL: https://github.com/apache/cloudstack/pull/11690
Description
When using Ceph RBD as primary storage on KVM, the agent currently tries to run:
mountpoint -q /mnt/<uuid>
This fails because RBD pools are not mounted like NFS or other network filesystems.
As a result, snapshot and template operations fail with errors such as:
libvirt failed to mount storage pool <uuid> at /mnt/<uuid>
This patch updates LibvirtStorageAdaptor to skip the mountpoint check when the storage pool type is RBD.
It prevents false errors while keeping the logic unchanged for NFS/NetFS pools.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Bug Severity
Major (affects snapshot/template functionality on Ceph RBD)
How Has This Been Tested?
CloudStack 4.21.0.0 + Ceph RBD backend (client.cloudstack user)
Created multiple VM snapshots → successfully registered in Ceph
Created templates from snapshots → completed without mountpoint errors
Verified no regressions on other pool types (NFS untouched)
Checked agent.log: no further mountpoint failures for RBD pools
Related issues
N/A (first-time fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#discussion_r2374559642
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -306,12 +306,27 @@ public void storagePoolRefresh(StoragePool pool) {
}
private void checkNetfsStoragePoolMounted(String uuid) {
Review Comment:
this is called only once by
https://github.com/apache/cloudstack/blob/4884f52c9088cdf20b3638480412ec49eaad10b5/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L879-L881
this PR seems not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "jeanvetorello (via GitHub)" <gi...@apache.org>.
jeanvetorello commented on code in PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#discussion_r2379285169
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -306,12 +306,27 @@ public void storagePoolRefresh(StoragePool pool) {
}
private void checkNetfsStoragePoolMounted(String uuid) {
Review Comment:
https://github.com/apache/cloudstack/issues/11724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#discussion_r2379403554
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -306,12 +306,27 @@ public void storagePoolRefresh(StoragePool pool) {
}
private void checkNetfsStoragePoolMounted(String uuid) {
Review Comment:
thanks @jeanvetorello
did you face the issue #11697 when you test with this patch or not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3325251794
<b>[SF] Trillian test result (tid-14419)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51416 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11690-t14419-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#discussion_r2374569173
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -306,12 +306,27 @@ public void storagePoolRefresh(StoragePool pool) {
}
private void checkNetfsStoragePoolMounted(String uuid) {
Review Comment:
@jeanvetorello
have you faced any issue in your testing ? any logs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3322347885
@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3322346565
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3315245382
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "jeanvetorello (via GitHub)" <gi...@apache.org>.
jeanvetorello commented on code in PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#discussion_r2379081635
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -306,12 +306,27 @@ public void storagePoolRefresh(StoragePool pool) {
}
private void checkNetfsStoragePoolMounted(String uuid) {
Review Comment:
thanks for the help ,
I’m going to open an issue describing the problem in detail, along with the logs, to see if you can help resolve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "jeanvetorello (via GitHub)" <gi...@apache.org>.
jeanvetorello commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3334606851
Thanks for the reviews.
I’ve realized that this PR is not the right fix for the issue.
Skipping the NFS check allowed snapshots to proceed, but it prevents the actual backup to secondary storage, which is required.
Therefore, this is not a valid solution.
The problem is in the way the KVM agent assigns/mounts the pool UUID when handling Ceph + NFS snapshots, and needs to be fixed in another way.
I’ll close this PR and continue investigating the correct approach. Sorry for the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "jeanvetorello (via GitHub)" <gi...@apache.org>.
jeanvetorello closed pull request #11690: KVM: skip mountpoint check for RBD storage pools
URL: https://github.com/apache/cloudstack/pull/11690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3314898370
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11690?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.62%. Comparing base ([`f9513b4`](https://app.codecov.io/gh/apache/cloudstack/commit/f9513b47bf8cda46c2cee7e31d4d662346bc7399?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`945646b`](https://app.codecov.io/gh/apache/cloudstack/commit/945646b4d7edb4b214dfaad84bb2841d9abe3745?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 83 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (f9513b4) and HEAD (945646b). Click for more details.
>
> <details><summary>HEAD has 4 uploads less than BASE</summary>
>
>| Flag | BASE (f9513b4) | HEAD (945646b) |
>|------|------|------|
>|uitests|3|1|
>|unittests|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11690 +/- ##
=============================================
- Coverage 17.36% 3.62% -13.74%
=============================================
Files 5886 441 -5445
Lines 525680 37136 -488544
Branches 64159 6808 -57351
=============================================
- Hits 91261 1346 -89915
+ Misses 424120 35626 -388494
+ Partials 10299 164 -10135
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11690/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11690/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.62% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11690/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11690?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3315246014
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: skip mountpoint check for RBD storage pools [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11690:
URL: https://github.com/apache/cloudstack/pull/11690#issuecomment-3315286153
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org