You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/07 00:56:00 UTC

[jira] [Commented] (NIFI-4160) SFTPTransfer should specify connection timeout

    [ https://issues.apache.org/jira/browse/NIFI-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077430#comment-16077430 ] 

ASF GitHub Bot commented on NIFI-4160:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1991

    NIFI-4160: SFTPTransfer connection timeout for opening channel.

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-4160

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1991
    
----
commit 9eb88e25cf8e324a946cdf909366b0db78c2ec57
Author: Koji Kawamura <ij...@apache.org>
Date:   2017-07-07T00:52:53Z

    NIFI-4160: SFTPTransfer connection timeout for opening channel.

----


> SFTPTransfer should specify connection timeout
> ----------------------------------------------
>
>                 Key: NIFI-4160
>                 URL: https://issues.apache.org/jira/browse/NIFI-4160
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.0.0
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>
> For FTP/SFTP, we use com.jcraft.jsch library. When XXXSFTP processor make use of the library, there are two occasions to set connection timeout. One is connecting a session (Socket), and the other is opening a SFTP channel.
> Currently we set a connection timeout which can be specified via processor property for connecting a session, but not for opening an SFTP channel.
> Then the library uses default 10ms x 2000 retry to open the channel. With slow SFTP servers it's possible that opening channel takes longer than 10ms, which can cause following error:
> {code}
> java.io.IOException: Failed to obtain connection to remote host due to com.jcraft.jsch.JSchException: channel is not opened
> {code}
> We should specify connection timeout for opening channel as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)