[GitHub] [superset] dvmarkusvogl commented on pull request #19572: fix(chartdata): disable sqlparse calls for chart data requests to improve querying performance

[GitBox <gi...@apache.org>]

dvmarkusvogl commented on PR #19572:
URL: https://github.com/apache/superset/pull/19572#issuecomment-1091847836

   > we currently rely heavily on sqlparse **for some very critical validation logic**
   SQL-Parses self-description:
   (pypi): sqlparse is a **non-validating** SQL parser for Python 
   (github) A **non-validating** SQL parser module for Python
   
   They seem very keen on not being used for validation.
   IMO the pythonic way would be to properly handle the database-response, and the fix above at least reduces the existing complexity.
   
   Also, the project had [3 days of activity](https://github.com/andialbrecht/sqlparse/commits/master) since October 2020, so I wouldn't expect much from them or rely to heavily from a project that hat 200+ open issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org