You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vgmartinez <gi...@git.apache.org> on 2016/03/23 12:54:13 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-692 Add setting to set s...
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/793
ZEPPELIN-692 Add setting to set s3 endpoint
### What is this PR for?
Add setting to set endpoint in S3 storage
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
* [ZEPPELIN-692](https://issues.apache.org/jira/browse/ZEPPELIN-692)
### How should this be tested?
set endpoint for your bucket in zeppelin-site.xml
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin ZEPPELIN-692
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/793.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #793
----
commit 6015d668765068a7e1b18f6112b2632529b35ec3
Author: vgmartinez <vi...@gmail.com>
Date: 2016-03-23T11:47:29Z
Add setting to set s3 endpoint
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-692 Add setting to set s...
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/793#issuecomment-200376077
@Leemoonsoo of course I had forgotten...;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-692 Add setting to set s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/793
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-692 Add setting to set s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/793#issuecomment-200389658
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-692 Add setting to set s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/793#issuecomment-200874185
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-692 Add setting to set s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/793#issuecomment-200367382
Could you add new configuration to [docs/install/install.md](https://github.com/apache/incubator-zeppelin/blob/master/docs/install/install.md#zeppelin-configuration) and [conf/zeppelin-env.sh.template](https://github.com/apache/incubator-zeppelin/blob/master/conf/zeppelin-env.sh.template#L33), too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---