[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4629: [QNN] Channel wise quantization - Quantize & Requantize

[GitBox <gi...@apache.org>]

tmoreau89 commented on a change in pull request #4629: [QNN] Channel wise quantization - Quantize & Requantize
URL: https://github.com/apache/incubator-tvm/pull/4629#discussion_r363431509
 
 

 ##########
 File path: include/tvm/relay/qnn/attrs.h
 ##########
 @@ -33,10 +33,14 @@ namespace qnn {
 
 /*! \brief Attribute for requantize operator */
 struct RequantizeAttrs : public tvm::AttrsNode<RequantizeAttrs> {
+  int axis;
   std::string rounding;
   DataType out_dtype;
 
   TVM_DECLARE_ATTRS(RequantizeAttrs, "relay.attrs.RequantizeAttrs") {
+    TVM_ATTR_FIELD(axis)
+      .describe("The output channel axis for channel wise quantization.")
 
 Review comment:
   explain what -1 means since it's a special value

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services