[jira] [Commented] (AIRFLOW-5508) Whitelist mechanism for StatsD metrics

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931051#comment-16931051 ] 

ASF GitHub Bot commented on AIRFLOW-5508:
-----------------------------------------

mikedias commented on pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
URL: https://github.com/apache/airflow/pull/6130
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Sometimes we don't need that all available metrics be sent to StatsD server when only a particular subset is relevant (e.g. scheduler or pool).
   
   One of the reasons for filtering out metrics is because some of them are based on dag ids, creating high cardinality metrics in the StatsD server, leading into scalability issues in an environment with many dags.
   
   This PR introduces the ability to control which metrics should be sent via whitelisting the metrics prefixes, keeping the default behavior of sending all if not specified.
   
   ### Tests
   
   - [x] My PR adds the following unit tests:
    - `tests.test_stats.TestStatsWithWhitelist`
   
   
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Whitelist mechanism for StatsD metrics
> --------------------------------------
>
>                 Key: AIRFLOW-5508
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5508
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: scheduler
>    Affects Versions: 1.10.5
>            Reporter: Mike Dias
>            Assignee: Mike Dias
>            Priority: Minor
>
> Sometimes we don't need that all available metrics be sent to StatsD server when only a particular subset is relevant (e.g. scheduler or pool).
> One of the reasons for filtering out metrics is because some of them are based on dag ids, creating high cardinality metrics in the StatsD server, leading into scalability issues in an environment with many dags.
> This feature aims to give the users the ability to control which metrics should be sent via whitelisting, keeping the default behavior of sending all if not specified.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)