You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/02 08:11:00 UTC
[GitHub] [inlong] bluewang opened a new pull request, #6374: [INLONG-6363][Dashboard] Group supports Kafka MQ types
bluewang opened a new pull request, #6374:
URL: https://github.com/apache/inlong/pull/6374
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes https://github.com/apache/inlong/issues/6363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6374: [INLONG-6363][Dashboard] InLong Group supports Kafka MQ
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6374:
URL: https://github.com/apache/inlong/pull/6374#discussion_r1012490287
##########
inlong-dashboard/src/locales/en.json:
##########
@@ -233,6 +233,9 @@
"meta.Group.AccessPeakPerSecond": "PeakRecords",
"meta.Group.Stripe/Second": "Stripe / Second",
"meta.Group.SingleStripMaximumLength": "Single Max Length",
+ "meta.Group.Partition": "Number of partitions",
+ "meta.Group.PartitionUnit": "Indivual",
Review Comment:
It is not necessary to use a `unit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng merged pull request #6374: [INLONG-6363][Dashboard] InLong Group supports Kafka MQ
Posted by GitBox <gi...@apache.org>.
leezng merged PR #6374:
URL: https://github.com/apache/inlong/pull/6374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] bluewang commented on a diff in pull request #6374: [INLONG-6363][Dashboard] Group supports Kafka MQ types
Posted by GitBox <gi...@apache.org>.
bluewang commented on code in PR #6374:
URL: https://github.com/apache/inlong/pull/6374#discussion_r1011468329
##########
inlong-dashboard/src/metas/groups/defaults/Kafka.ts:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { DataWithBackend } from '@/metas/DataWithBackend';
+import i18n from '@/i18n';
+import { GroupInfo } from '../common/GroupInfo';
+
+const { I18n, FormField } = DataWithBackend;
+
+export default class KafkaGroup extends GroupInfo implements DataWithBackend {
+ @FormField({
+ type: 'inputnumber',
+ rules: [{ required: true }],
+ suffix: i18n.t('meta.Group.PartitionUnit'),
+ props: {
+ min: 1,
+ precision: 0,
+ },
+ })
+ @I18n('meta.Group.Partition')
+ numPartitions: number;
+
+ @FormField({
+ type: 'inputnumber',
+ rules: [{ required: true }],
+ initialValue: 1,
+ suffix: i18n.t('meta.Group.PartitionUnit'),
+ props: {
+ min: 1,
+ precision: 0,
+ },
+ })
+ @I18n('meta.Group.AccessSize')
+ replicationFactor: number;
Review Comment:
ok. I changed it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] bluewang commented on a diff in pull request #6374: [INLONG-6363][Dashboard] Group supports Kafka MQ types
Posted by GitBox <gi...@apache.org>.
bluewang commented on code in PR #6374:
URL: https://github.com/apache/inlong/pull/6374#discussion_r1012452131
##########
inlong-dashboard/src/metas/groups/defaults/Kafka.ts:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { DataWithBackend } from '@/metas/DataWithBackend';
+import i18n from '@/i18n';
+import { GroupInfo } from '../common/GroupInfo';
+
+const { I18n, FormField } = DataWithBackend;
+
+export default class KafkaGroup extends GroupInfo implements DataWithBackend {
+ @FormField({
+ type: 'inputnumber',
+ rules: [{ required: true }],
+ suffix: i18n.t('meta.Group.PartitionUnit'),
+ props: {
+ min: 1,
+ precision: 0,
+ },
+ })
+ @I18n('meta.Group.Partition')
+ numPartitions: number;
+
+ @FormField({
+ type: 'inputnumber',
+ rules: [{ required: true }],
+ initialValue: 1,
+ suffix: i18n.t('meta.Group.PartitionUnit'),
+ props: {
+ min: 1,
+ precision: 0,
+ },
+ })
+ @I18n('meta.Group.AccessSize')
+ replicationFactor: number;
Review Comment:
Currently, all Kafka topics in an inlong group must have the same number of partitions and replication factors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #6374: [INLONG-6363][Dashboard] InLong Group supports Kafka MQ
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #6374:
URL: https://github.com/apache/inlong/pull/6374#discussion_r1012533333
##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -233,6 +233,8 @@
"meta.Group.AccessPeakPerSecond": "每秒接入峰值",
"meta.Group.Stripe/Second": "条/秒",
"meta.Group.SingleStripMaximumLength": "单条最大长度",
+ "meta.Group.Partition": "分区数",
Review Comment:
The key should use `meta.Group.Kafka.Partition`. Others similar to the same need to be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6374: [INLONG-6363][Dashboard] Group supports Kafka MQ types
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6374:
URL: https://github.com/apache/inlong/pull/6374#discussion_r1011455630
##########
inlong-dashboard/src/metas/groups/defaults/Kafka.ts:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { DataWithBackend } from '@/metas/DataWithBackend';
+import i18n from '@/i18n';
+import { GroupInfo } from '../common/GroupInfo';
+
+const { I18n, FormField } = DataWithBackend;
+
+export default class KafkaGroup extends GroupInfo implements DataWithBackend {
+ @FormField({
+ type: 'inputnumber',
+ rules: [{ required: true }],
+ suffix: i18n.t('meta.Group.PartitionUnit'),
+ props: {
+ min: 1,
+ precision: 0,
+ },
+ })
+ @I18n('meta.Group.Partition')
+ numPartitions: number;
+
+ @FormField({
+ type: 'inputnumber',
+ rules: [{ required: true }],
+ initialValue: 1,
+ suffix: i18n.t('meta.Group.PartitionUnit'),
+ props: {
+ min: 1,
+ precision: 0,
+ },
+ })
+ @I18n('meta.Group.AccessSize')
+ replicationFactor: number;
Review Comment:
The `numPartitions` and `replicationFactor` should be in InlongStream layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #6374: [INLONG-6363][Dashboard] InLong Group supports Kafka MQ
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #6374:
URL: https://github.com/apache/inlong/pull/6374#discussion_r1012533333
##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -233,6 +233,8 @@
"meta.Group.AccessPeakPerSecond": "每秒接入峰值",
"meta.Group.Stripe/Second": "条/秒",
"meta.Group.SingleStripMaximumLength": "单条最大长度",
+ "meta.Group.Partition": "分区数",
Review Comment:
The key use `meta.Group.Kafka.Partition`. Others similar to the same need to be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org