[GitHub] [solr] cpoerschke commented on a change in pull request #726: SOLR-16072: make solr.jetty metrics reappear again

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #726:
URL: https://github.com/apache/solr/pull/726#discussion_r819898742



##########
File path: solr/core/build.gradle
##########
@@ -139,12 +139,12 @@ dependencies {
   implementation 'org.apache.logging.log4j:log4j-core'
   implementation 'org.apache.logging.log4j:log4j-slf4j-impl'
 
-  implementation 'io.dropwizard.metrics:metrics-core'
-  implementation ('io.dropwizard.metrics:metrics-graphite', {
+  compileOnlyApi 'io.dropwizard.metrics:metrics-core'

Review comment:
       Please feel free to add a comment on the PR/branch; I'm not yet familiar enough with this gradle stuff to put a helpful and accurate comment. But diving into a mystery like this here is a fun way to learn more about gradle.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org