You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/19 15:56:00 UTC
[jira] [Work logged] (HIVE-26148) Keep MetaStoreFilterHook interface compatibility after introducing catalogs
[ https://issues.apache.org/jira/browse/HIVE-26148?focusedWorklogId=792780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792780 ]
ASF GitHub Bot logged work on HIVE-26148:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/22 15:55
Start Date: 19/Jul/22 15:55
Worklog Time Spent: 10m
Work Description: wecharyu commented on PR #3218:
URL: https://github.com/apache/hive/pull/3218#issuecomment-1189229215
Gentle Ping @pvary @nrg4878
Issue Time Tracking
-------------------
Worklog Id: (was: 792780)
Time Spent: 2h 50m (was: 2h 40m)
> Keep MetaStoreFilterHook interface compatibility after introducing catalogs
> ---------------------------------------------------------------------------
>
> Key: HIVE-26148
> URL: https://issues.apache.org/jira/browse/HIVE-26148
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 3.0.0
> Reporter: Wechar
> Assignee: Wechar
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-2
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Hive 3.0 introduce catalog concept, when we upgrade hive dependency version from 2.3 to 3.x, we found some interfaces of *MetaStoreFilterHook* are not compatible:
> {code:bash}
> git show ba8a99e115 -- standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java
> {code}
> {code:bash}
> --- a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java
> +++ b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java
> /**
> * Filter given list of tables
> - * @param dbName
> - * @param tableList
> + * @param catName catalog name
> + * @param dbName database name
> + * @param tableList list of table returned by the metastore
> * @return List of filtered table names
> */
> - public List<String> filterTableNames(String dbName, List<String> tableList) throws MetaException;
> + List<String> filterTableNames(String catName, String dbName, List<String> tableList)
> + throws MetaException;
> {code}
> We can remain the previous interfaces and use the default catalog to implement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)