[GitHub] [guacamole-server] necouchman commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China

[GitBox <gi...@apache.org>]

necouchman commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r856940840


##########
Dockerfile:
##########
@@ -145,6 +154,8 @@ RUN apt-get update
     apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $RUNTIME_DEPENDENCIES                && \
     apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $(cat "${PREFIX_DIR}"/DEPENDENCIES)  && \
     rm -rf /var/lib/apt/lists/*
+# Reset /etc/apt/sources.list file
+RUN test -f  /etc/apt/sources.list.bak && mv /etc/apt/sources.list.bak /etc/apt/sources.list

Review Comment:
   Why reset things? That would seem to add inconsistency between how the image is built and the running system??



##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
 
 # The Ubuntu image that should be used as the basis for the guacd image
 ARG UBUNTU_BASE_IMAGE=21.10
-
 # Use Debian as base for the build
 FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
 
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"

Review Comment:
   Are these the default repository locations? I'm hesitant to override defaults by default, if that makes sense - I don't mind providing a way to specify a mirror, but I'm not sure I like the idea of having a particular mirror be called out, here, unless the admin specifically wants it.



##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
 
 # The Ubuntu image that should be used as the basis for the guacd image
 ARG UBUNTU_BASE_IMAGE=21.10
-
 # Use Debian as base for the build
 FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
 
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
 #
 # The Debian repository that should be preferred for dependencies (this will be
 # added to /etc/apt/sources.list if not already present)
 #
 # NOTE: Due to limitations of the Docker image build process, this value is
 # duplicated in an ARG in the second stage of the build.
 #
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish

Review Comment:
   This will need some further discussion - we have gone back-and-forth between debian and ubuntu, and between things like debian-stable and what you see, here. There are reasons for this - primarily they come down to the versions of libraries, mainly FreeRDP and libssh2, that are included in these base images, and features that either work or do not work with given versions of the libraries. Is there a particular reason why you want to change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org