You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2016/04/21 00:34:52 UTC
incubator-kudu git commit: Fix compile issues on OS X
Repository: incubator-kudu
Updated Branches:
refs/heads/master 2eba21c93 -> 596a3018a
Fix compile issues on OS X
Recent commits have introduced some code that compiles with Linux/libstdcxx but
not OS X/libcxx.
Change-Id: I607b1ba7f551eeca5ebb34a61934e5d5c084a2c1
Reviewed-on: http://gerrit.cloudera.org:8080/2825
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/596a3018
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/596a3018
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/596a3018
Branch: refs/heads/master
Commit: 596a3018a3ef1e5702959477d768d0d5a409178c
Parents: 2eba21c
Author: Dan Burkert <da...@cloudera.com>
Authored: Wed Apr 20 15:09:21 2016 -0700
Committer: Dan Burkert <da...@cloudera.com>
Committed: Wed Apr 20 22:34:16 2016 +0000
----------------------------------------------------------------------
src/kudu/rpc/rpcz_store.cc | 1 +
src/kudu/util/trace_metrics.cc | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/596a3018/src/kudu/rpc/rpcz_store.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/rpcz_store.cc b/src/kudu/rpc/rpcz_store.cc
index 33997fe..f741881 100644
--- a/src/kudu/rpc/rpcz_store.cc
+++ b/src/kudu/rpc/rpcz_store.cc
@@ -18,6 +18,7 @@
#include "kudu/rpc/rpcz_store.h"
#include <algorithm>
+#include <array>
#include <glog/stl_logging.h>
#include <mutex> // for unique_lock
#include <string>
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/596a3018/src/kudu/util/trace_metrics.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/trace_metrics.cc b/src/kudu/util/trace_metrics.cc
index 81c4df5..20569fc 100644
--- a/src/kudu/util/trace_metrics.cc
+++ b/src/kudu/util/trace_metrics.cc
@@ -38,7 +38,7 @@ static InternMap* g_intern_map;
} // anonymous namespace
const char* TraceMetrics::InternName(const string& name) {
- DCHECK(std::all_of(name.begin(), name.end(), isprint))
+ DCHECK(std::all_of(name.begin(), name.end(), [] (char c) { return isprint(c); } ))
<< "not printable: " << name;
debug::ScopedLeakCheckDisabler no_leakcheck;