You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by "Norbert Luksa (Jira)" <ji...@apache.org> on 2020/02/27 10:14:00 UTC

[jira] [Created] (ORC-604) Check in StringDictionary.getValueByIndex is too permissive

Norbert Luksa created ORC-604:
---------------------------------

             Summary: Check in StringDictionary.getValueByIndex is too permissive
                 Key: ORC-604
                 URL: https://issues.apache.org/jira/browse/ORC-604
             Project: ORC
          Issue Type: Bug
          Components: C++
            Reporter: Norbert Luksa
            Assignee: Norbert Luksa


The check [here|https://github.com/apache/orc/blob/5613a88a59a7c6656444605e6d24984d1ac335ce/c%2B%2B/include/orc/Vector.hh#L137] is too permissive, requires only that index < dictionaryOffset.size(), but a 
 [few lines later|https://github.com/apache/orc/blob/5613a88a59a7c6656444605e6d24984d1ac335ce/c%2B%2B/include/orc/Vector.hh#L144] dictionaryOffset is indexed with index + 1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)