You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/23 06:42:56 UTC

[GitHub] [airflow] juneoh opened a new pull request #12557: Add ORC source format support for BigQueryHook load jobs

juneoh opened a new pull request #12557:
URL: https://github.com/apache/airflow/pull/12557


   Add the missing ORC format into the allowlist in BigQueryHook load jobs, in order to fully support all formats provided in BigQuery API.
   
   Closes: #12556


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12557: Add ORC source format support for BigQueryHook load jobs

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #12557:
URL: https://github.com/apache/airflow/pull/12557#issuecomment-731960481

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] juneoh commented on pull request #12557: Add ORC source format support for BigQueryHook load jobs

Posted by GitBox <gi...@apache.org>.

juneoh commented on pull request #12557:
URL: https://github.com/apache/airflow/pull/12557#issuecomment-732027150


   Thanks turbaszek for the feedback. As `GCSToBigQueryOperator` still relies on `BigQueryHook.run_load()`, I though it would be quicker to change the method albeit deprecated, rather than to rewrite the operator.
   
   But you are right, deprecated is deprecated, so I do agree to the sentiment. As `run_load` is a validation wrapper on top of `insert_job`, would you rather recommend moving that validation into `GCSToBigQueryOperator` instead, to eliminate the deprecated `run_load` path and call `insert_job` directly?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #12557: Add ORC source format support for BigQueryHook load jobs

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #12557:
URL: https://github.com/apache/airflow/pull/12557#issuecomment-731976741


   [The Workflow run](https://github.com/apache/airflow/actions/runs/378425172) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] juneoh closed pull request #12557: Add ORC source format support for BigQueryHook load jobs

Posted by GitBox <gi...@apache.org>.

juneoh closed pull request #12557:
URL: https://github.com/apache/airflow/pull/12557


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #12557: Add ORC source format support for BigQueryHook load jobs

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #12557:
URL: https://github.com/apache/airflow/pull/12557#issuecomment-731977254


   [The Workflow run](https://github.com/apache/airflow/actions/runs/378426942) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #12557: Add ORC source format support for BigQueryHook load jobs

Posted by GitBox <gi...@apache.org>.

turbaszek commented on pull request #12557:
URL: https://github.com/apache/airflow/pull/12557#issuecomment-732018372


   The `run_load` method is deprecated and users should use `insert_job` method which supports everything possible 😉 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] juneoh commented on pull request #12557: Add ORC source format support for BigQueryHook load jobs

Posted by GitBox <gi...@apache.org>.

juneoh commented on pull request #12557:
URL: https://github.com/apache/airflow/pull/12557#issuecomment-732030048


   Oops, turbaszek has already provided a kind comment at https://github.com/apache/airflow/issues/12556#issuecomment-732020880. Looks like there is already a different PR that should resolve the deprecated path as well.
   
   Thanks turbaszek, I'll close this PR and follow the other thread!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org