You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stefankandic (via GitHub)" <gi...@apache.org> on 2024/02/26 16:12:33 UTC
[PR] Disable parquet filter pushdown when working with non default collated strings [spark]
stefankandic opened a new pull request, #45262:
URL: https://github.com/apache/spark/pull/45262
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Disable parquet filter pushdown when expression is referencing a non default collated column/field in a struct.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Because parquet min/max stats don't know about the concept of collation and data skipping based on them could lead to incorrect results for certain collation types (lowercase collation for example).
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Users should now always get the correct result when using collated string columns.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
With new UTs in `ParquetFilterSuite`
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1509062485
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala:
##########
@@ -279,4 +279,23 @@ object DataSourceUtils extends PredicateHelper {
dataFilters.flatMap(extractPredicatesWithinOutputSet(_, partitionSet))
(ExpressionSet(partitionFilters ++ extraPartitionFilter).toSeq, dataFilters)
}
+
+ /**
+ * Determines whether a filter should be pushed down to the data source or not.
+ *
+ * @param expression The filter expression to be evaluated.
+ * @return A boolean indicating whether the filter should be pushed down or not.
+ */
+ def shouldPushFilter(expression: Expression): Boolean = {
+ def checkRecursive(expression: Expression): Boolean = expression match {
Review Comment:
it's simply
```
expression.exists {
case ...
case _ => false
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510848157
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala:
##########
@@ -2228,6 +2228,50 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
}
}
}
+
+ test("disable filter pushdown for collated strings") {
Review Comment:
I think this PR does not target parquet only, but all file sources. Shall we put the test in `FileBasedDataSourceSuite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #45262:
URL: https://github.com/apache/spark/pull/45262#issuecomment-1976314274
This LGTM, but the same problem should exist in custom data sources. If we write string with collation to a custom data source, everything works as the value is still UTF8String, but any pushdown can go wrong (not only filter, but also aggregate or other operators).
I think one solution is to add a new data source API (in both DS v1 and v2) to indicate the support of collation. By default it's false and Spark should fail when writing string with collation to a custom data source. This is unrelated to this PR and we can do it in a followup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "mkaravel (via GitHub)" <gi...@apache.org>.
mkaravel commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1506066687
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala:
##########
@@ -279,4 +279,26 @@ object DataSourceUtils extends PredicateHelper {
dataFilters.flatMap(extractPredicatesWithinOutputSet(_, partitionSet))
(ExpressionSet(partitionFilters ++ extraPartitionFilter).toSeq, dataFilters)
}
+
+ /**
+ * Determines whether a filter should be pushed down to the data source or not.
+ *
+ * @param expression The filter expression to be evaluated.
+ * @return A boolean indicating whether the filter should be pushed down or not.
+ */
+ def shouldPushFilter(expression: Expression): Boolean = {
+ def checkRecursive(expression: Expression): Boolean = expression match {
+ case _: Attribute | _: GetStructField =>
+ // don't push down filters for columns with non-default collation
+ // as it could lead to incorrect results
+ expression.dataType match {
+ case st: StringType => st.isDefaultCollation
+ case struct: StructType => !SchemaUtils.containsNonDefaultCollatedString(struct)
+ case _ => true
Review Comment:
What about arrays and maps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1509060591
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala:
##########
@@ -293,4 +293,29 @@ private[spark] object SchemaUtils {
* @return The escaped string.
*/
def escapeMetaCharacters(str: String): String = SparkSchemaUtils.escapeMetaCharacters(str)
+
+ /**
+ * Checks if a given data type has a non-default collation string type.
+ */
+ def hasNonDefaultCollatedString(dt: DataType): Boolean = {
+ typeExistsRecursively(dt) {
+ case st: StringType => !st.isDefaultCollation
+ case _ => false
+ }
+ }
+
+ /**
+ * Recursively checks whether a given predicate holds true for any data type
+ * within the specified data type.
+ */
+ def typeExistsRecursively(dt: DataType)(f: DataType => Boolean): Boolean = dt match {
Review Comment:
isn't it just `DataType#existsRecursively`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #45262:
URL: https://github.com/apache/spark/pull/45262#issuecomment-1978722134
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510842313
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala:
##########
@@ -160,8 +160,11 @@ object FileSourceStrategy extends Strategy with PredicateHelper with Logging {
// - filters that need to be evaluated again after the scan
val filterSet = ExpressionSet(filters)
+ val filtersToPush = filters
+ .filter(f => DataSourceUtils.shouldPushFilter(f))
Review Comment:
```suggestion
val filtersToPush = filters.filter(f => DataSourceUtils.shouldPushFilter(f))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510841679
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala:
##########
@@ -279,4 +279,21 @@ object DataSourceUtils extends PredicateHelper {
dataFilters.flatMap(extractPredicatesWithinOutputSet(_, partitionSet))
(ExpressionSet(partitionFilters ++ extraPartitionFilter).toSeq, dataFilters)
}
+
+ /**
+ * Determines whether a filter should be pushed down to the data source or not.
+ *
+ * @param expression The filter expression to be evaluated.
+ * @return A boolean indicating whether the filter should be pushed down or not.
+ */
+ def shouldPushFilter(expression: Expression): Boolean = {
+ expression.deterministic && !expression.exists {
+ case childExpression @ (_: Attribute | _: GetStructField) =>
Review Comment:
```suggestion
case e @ (_: Attribute | _: GetStructField) =>
```
`.exists` visits all nodes in the tree, not only the children of the root node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "stefankandic (via GitHub)" <gi...@apache.org>.
stefankandic commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1509122961
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala:
##########
@@ -293,4 +293,29 @@ private[spark] object SchemaUtils {
* @return The escaped string.
*/
def escapeMetaCharacters(str: String): String = SparkSchemaUtils.escapeMetaCharacters(str)
+
+ /**
+ * Checks if a given data type has a non-default collation string type.
+ */
+ def hasNonDefaultCollatedString(dt: DataType): Boolean = {
+ typeExistsRecursively(dt) {
+ case st: StringType => !st.isDefaultCollation
+ case _ => false
+ }
+ }
+
+ /**
+ * Recursively checks whether a given predicate holds true for any data type
+ * within the specified data type.
+ */
+ def typeExistsRecursively(dt: DataType)(f: DataType => Boolean): Boolean = dt match {
Review Comment:
🤦 yes, my bad sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "stefankandic (via GitHub)" <gi...@apache.org>.
stefankandic commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1507649566
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala:
##########
@@ -279,4 +279,26 @@ object DataSourceUtils extends PredicateHelper {
dataFilters.flatMap(extractPredicatesWithinOutputSet(_, partitionSet))
(ExpressionSet(partitionFilters ++ extraPartitionFilter).toSeq, dataFilters)
}
+
+ /**
+ * Determines whether a filter should be pushed down to the data source or not.
+ *
+ * @param expression The filter expression to be evaluated.
+ * @return A boolean indicating whether the filter should be pushed down or not.
+ */
+ def shouldPushFilter(expression: Expression): Boolean = {
+ def checkRecursive(expression: Expression): Boolean = expression match {
+ case _: Attribute | _: GetStructField =>
+ // don't push down filters for columns with non-default collation
+ // as it could lead to incorrect results
+ expression.dataType match {
+ case st: StringType => st.isDefaultCollation
+ case struct: StructType => !SchemaUtils.containsNonDefaultCollatedString(struct)
+ case _ => true
Review Comment:
great catch! fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "stefankandic (via GitHub)" <gi...@apache.org>.
stefankandic commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510984603
##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -1246,6 +1246,50 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("disable filter pushdown for collated strings") {
Review Comment:
the issue there is that some data sources still don't support collations (orc, parquet, csv) - should we maybe just test for parquet now, and as we add support for others we also add them to the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510844088
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala:
##########
@@ -63,7 +63,8 @@ private[sql] object PruneFileSourcePartitions extends Rule[LogicalPlan] {
_))
if filters.nonEmpty && fsRelation.partitionSchema.nonEmpty =>
val normalizedFilters = DataSourceStrategy.normalizeExprs(
- filters.filter(f => f.deterministic && !SubqueryExpression.hasSubquery(f)),
+ filters.filter(f => !SubqueryExpression.hasSubquery(f)
+ && DataSourceUtils.shouldPushFilter(f)),
Review Comment:
```suggestion
filters.filter(f => !SubqueryExpression.hasSubquery(f) && DataSourceUtils.shouldPushFilter(f)),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510844538
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala:
##########
@@ -70,9 +70,10 @@ abstract class FileScanBuilder(
}
override def pushFilters(filters: Seq[Expression]): Seq[Expression] = {
- val (deterministicFilters, nonDeterminsticFilters) = filters.partition(_.deterministic)
+ val (filtersToPush, filtersToIgnore) = filters
+ .partition(DataSourceUtils.shouldPushFilter)
Review Comment:
```suggestion
val (filtersToPush, filtersToIgnore) = filters.partition(DataSourceUtils.shouldPushFilter)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510845686
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala:
##########
@@ -70,9 +70,10 @@ abstract class FileScanBuilder(
}
override def pushFilters(filters: Seq[Expression]): Seq[Expression] = {
- val (deterministicFilters, nonDeterminsticFilters) = filters.partition(_.deterministic)
+ val (filtersToPush, filtersToIgnore) = filters
+ .partition(DataSourceUtils.shouldPushFilter)
Review Comment:
We do not ignore these filters, but they will remain in the query plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510844538
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala:
##########
@@ -70,9 +70,10 @@ abstract class FileScanBuilder(
}
override def pushFilters(filters: Seq[Expression]): Seq[Expression] = {
- val (deterministicFilters, nonDeterminsticFilters) = filters.partition(_.deterministic)
+ val (filtersToPush, filtersToIgnore) = filters
+ .partition(DataSourceUtils.shouldPushFilter)
Review Comment:
```suggestion
val (filtersToPush, filtersToRemain) = filters.partition(DataSourceUtils.shouldPushFilter)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510997197
##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -1246,6 +1246,50 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("disable filter pushdown for collated strings") {
Review Comment:
oh, then this is fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #45262: [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings
URL: https://github.com/apache/spark/pull/45262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "stefankandic (via GitHub)" <gi...@apache.org>.
stefankandic commented on PR #45262:
URL: https://github.com/apache/spark/pull/45262#issuecomment-1978441754
@cloud-fan are we okay to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47168][SQL] Disable parquet filter pushdown when working with non default collated strings [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45262:
URL: https://github.com/apache/spark/pull/45262#discussion_r1510970156
##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -1246,6 +1246,50 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("disable filter pushdown for collated strings") {
Review Comment:
The test case should be put in the loop so that all file sources are tested.
##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -1246,6 +1246,50 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("disable filter pushdown for collated strings") {
Review Comment:
The test case should be put in the loop in this test suite so that all file sources are tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org