You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/06 19:47:07 UTC
[GitHub] [kafka] ryannedolan opened a new pull request #10983: mention IdentityReplicationPolicy in ops docs
ryannedolan opened a new pull request #10983:
URL: https://github.com/apache/kafka/pull/10983
IdentityReplicationPolicy was added to MM2 in 3.0.0, so we note it in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on a change in pull request #10983: mention IdentityReplicationPolicy in ops docs
Posted by GitBox <gi...@apache.org>.
mimaison commented on a change in pull request #10983:
URL: https://github.com/apache/kafka/pull/10983#discussion_r705288892
##########
File path: docs/ops.html
##########
@@ -845,6 +845,11 @@ <h5 class="anchor-heading"><a id="georeplication-topic-naming" class="anchor-lin
If you need further control over how replicated topics are named, you can implement a custom <code>ReplicationPolicy</code> and override <code>replication.policy.class</code> (default is <code>DefaultReplicationPolicy</code>) in the MirrorMaker configuration.
</p>
+ <p>
+ As a special case, MirrorMaker includes <a href="https://github.com/apache/kafka/blob/trunk/connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/IdentityReplicationPolicy.java">IdentityReplicationPolicy</a> (since version 3.0.0), which does not rename topics. This is useful for simple one-way replication topologies, where topic renaming is not strictly necessary; however, be careful not to introduce cycles when using <code>IdentityReplicationPolicy</code>, since this can result in the same records being replicated in an infinite loop.
Review comment:
What about linking to the javadoc for `IdentityReplicationPolicy`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10983: mention IdentityReplicationPolicy in ops docs
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10983:
URL: https://github.com/apache/kafka/pull/10983#discussion_r665019951
##########
File path: docs/ops.html
##########
@@ -845,6 +845,11 @@ <h5 class="anchor-heading"><a id="georeplication-topic-naming" class="anchor-lin
If you need further control over how replicated topics are named, you can implement a custom <code>ReplicationPolicy</code> and override <code>replication.policy.class</code> (default is <code>DefaultReplicationPolicy</code>) in the MirrorMaker configuration.
</p>
+ <p>
+ As a special case, MirrorMaker includes <a href="https://github.com/apache/kafka/blob/trunk/connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/IdentityReplicationPolicy.java">IdentityReplicationPolicy</a> (since version 3.0.0), which does not rename topics. This is useful for simple one-way replication topologies, where topic renaming is not strictly necessary; however, be careful not to introduce cycles when using <code>IdentityReplicationPolicy</code>, since this can result in the same records being replicated in an infinite loop.
Review comment:
I'm not sure if we really need to put the source code link here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org