[GitHub] [spark] srowen commented on a change in pull request #24086: [SPARK-27155][TEST] Parameterize Oracle docker image name

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24086: [SPARK-27155][TEST] Parameterize Oracle docker image name
URL: https://github.com/apache/spark/pull/24086#discussion_r268184442
 
 

 ##########
 File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
 ##########
 @@ -78,11 +81,15 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLCo
     conn.prepareStatement(
       "CREATE TABLE ts_with_timezone (id NUMBER(10), t TIMESTAMP WITH TIME ZONE)").executeUpdate()
     conn.prepareStatement(
-      "INSERT INTO ts_with_timezone VALUES " +
-        "(1, to_timestamp_tz('1999-12-01 11:00:00 UTC','YYYY-MM-DD HH:MI:SS TZR'))").executeUpdate()
+      """
+        |INSERT INTO ts_with_timezone VALUES (
+        |1, to_timestamp_tz('1999-12-01 11:00:00 UTC','YYYY-MM-DD HH:MI:SS TZR'))
+         """.stripMargin).executeUpdate()
 
 Review comment:
   Or @lipzhu why did this part change? I may be missing it but it seems like just a formatting change. I don't think it's necessary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org