You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "silentxingtian (via GitHub)" <gi...@apache.org> on 2024/03/24 13:35:31 UTC
[PR] fix the bug #3083,support recreat the hive table [paimon]
silentxingtian opened a new pull request, #3084:
URL: https://github.com/apache/paimon/pull/3084
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the bug #3083,support recreat the hive table [paimon]
Posted by "silentxingtian (via GitHub)" <gi...@apache.org>.
silentxingtian commented on code in PR #3084:
URL: https://github.com/apache/paimon/pull/3084#discussion_r1540347795
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java:
##########
@@ -124,16 +125,28 @@ public List<Long> listAllIds() {
}
}
+ /** Check TableScheme is be modified. */
+ public void checkTableSchema(TableSchema oldSchema, TableSchema newSchema) {
+ boolean isCommon =
+ oldSchema.version() == newSchema.version()
+ && oldSchema.id() == newSchema.id()
Review Comment:
Okay, if there's no change in the entire logic, I'll remove the schema id and options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the bug #3083,support recreat the hive table [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3084:
URL: https://github.com/apache/paimon/pull/3084#discussion_r1538510530
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java:
##########
@@ -124,16 +125,28 @@ public List<Long> listAllIds() {
}
}
+ /** Check TableScheme is be modified. */
+ public void checkTableSchema(TableSchema oldSchema, TableSchema newSchema) {
+ boolean isCommon =
+ oldSchema.version() == newSchema.version()
+ && oldSchema.id() == newSchema.id()
Review Comment:
I don't think we need to compare schema id and options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hive] Support recreate the hive table [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3084:
URL: https://github.com/apache/paimon/pull/3084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the bug #3083,support recreat the hive table [paimon]
Posted by "silentxingtian (via GitHub)" <gi...@apache.org>.
silentxingtian commented on PR #3084:
URL: https://github.com/apache/paimon/pull/3084#issuecomment-2021771404
> Can you add test for this?
ok,I will write a test case code and submit it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org