You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2015/05/06 05:33:58 UTC

[jira] [Updated] (HDFS-3488) BlockPoolSliceScanner#getNewBlockScanTime does not handle numbers > 31 bits properly

     [ https://issues.apache.org/jira/browse/HDFS-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated HDFS-3488:
-----------------------------------
    Labels: BB2015-05-TBR  (was: )

> BlockPoolSliceScanner#getNewBlockScanTime does not handle numbers > 31 bits properly
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-3488
>                 URL: https://issues.apache.org/jira/browse/HDFS-3488
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-3488.001.patch
>
>
> This code does not handle the case where period > 2**31 properly:
> {code}
>     long period = Math.min(scanPeriod, 
>                            Math.max(blockMap.size(),1) * 600 * 1000L);
>     int periodInt = Math.abs((int)period);
>     return System.currentTimeMillis() - scanPeriod + 
>         DFSUtil.getRandom().nextInt(periodInt);
> {code}
> So, for example, if period = 0x100000000, we'll map that to 0, and so forth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)