[jira] [Commented] (LUCENE-7875) Rename or move most of MultiFields

["Alan Woodward (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634232#comment-16634232 ] 

Alan Woodward commented on LUCENE-7875:
---------------------------------------

> getTermDocsEnum and getTermPositionsEnum which are basically the same thing

A blast from the past, that one... they can definitely be merged into a getPostingsEnum() method.

> Rename or move most of MultiFields
> ----------------------------------
>
>                 Key: LUCENE-7875
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7875
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: master (8.0)
>
>         Attachments: LUCENE-7875.patch
>
>
> MultiFields.java has a bunch of static methods that provide a single LeafReader's view over a bunch of things.
> These could perhaps go to ReaderUtil:
> * {{Bits getLiveDocs(IndexReader reader)}}
> * {{FieldInfos getMergedFieldInfos(IndexReader reader)}} (removing "Merged" in its name which seems inconsistent, or replace with "Multi")
> These could perhaps go to MultiTerms:
> * {{Collection<String> getIndexedFields(IndexReader reader)}}
> * {{Terms getTerms(IndexReader r, String field)}}
> * {{PostingsEnum getTermDocsEnum(IndexReader r, String field, BytesRef term)}}
> Finally, the MultiFields instance itself, implementing {{Fields}} along with the static utility method {{Fields getFields(IndexReader reader)}} could perhaps remain until we can finally remove it (or move to a test classpath or something) when there is no more purpose for Fields.java.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org