[GitHub] GJL commented on a change in pull request #7632: [FLINK-11362] Port TaskManagerComponentsStartupShutdownTest to new co…

[GitBox <gi...@apache.org>]

GJL commented on a change in pull request #7632: [FLINK-11362] Port TaskManagerComponentsStartupShutdownTest to new co…
URL: https://github.com/apache/flink/pull/7632#discussion_r253484764
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
 ##########
 @@ -230,6 +233,78 @@ public void teardown() throws Exception {
 	@Rule
 	public TestName name = new TestName();
 
+	@Test
+	public void testTaskManagerServicesShutdown() throws Exception {
+		final TaskSlotTable taskSlotTable = new TaskSlotTable(Collections.singleton(ResourceProfile.UNKNOWN), timerService);
+
+		final JobLeaderService jobLeaderService = new JobLeaderService(taskManagerLocation);
+
+		final long heartbeatInterval = 1000L;
+		final long heartbeatTimeout = 1000L;
+
+		final HeartbeatServices heartbeatServices = new HeartbeatServices(heartbeatInterval, heartbeatTimeout);
 
 Review comment:
   Definition/declaration should be closer to `TaskExecutor` creation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services