You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Pierre Smits (JIRA)" <ji...@apache.org> on 2016/06/18 17:18:05 UTC
[jira] [Updated] (OFBIZ-7413) Enforce noninstantiability to
ProductPromoWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre Smits updated OFBIZ-7413:
--------------------------------
Summary: Enforce noninstantiability to ProductPromoWorker class (was: ProductPromoWorker class)
> Enforce noninstantiability to ProductPromoWorker class
> ------------------------------------------------------
>
> Key: OFBIZ-7413
> URL: https://issues.apache.org/jira/browse/OFBIZ-7413
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: Trunk
> Reporter: Rishi Solanki
> Priority: Minor
> Attachments: OFBIZ-7413.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String resource = "OrderUiLabels";
> public static final String resource_error = "OrderErrorUiLabels";
> public static final int decimals = UtilNumber.getBigDecimalScale("order.decimals");
> public static final int rounding = UtilNumber.getBigDecimalRoundingMode("order.rounding");
> public static final MathContext generalRounding = new MathContext(10);
> {code}
> - Make following methods protected static methods as private
> {code}
> protected static boolean hasOrderTotalCondition()
> protected static boolean runProductPromoRules()
> protected static void runProductPromos()
> protected static boolean checkCondition()
> protected static boolean checkConditionsForItem()
> protected static boolean checkConditionForItem()
> protected static ActionResultInfo performAction(
> protected static List<ShoppingCartItem> getCartItemsUsed()
> protected static BigDecimal getCartItemsUsedTotalAmount()
> protected static void distributeDiscountAmount()
> protected static Integer findPromoItem()
> protected static Integer findAdjustment()
> protected static boolean isProductOld()
> protected static void handleProductPromoCategories()
> protected static void getAllProductIds()
> protected static void handleProductPromoProducts()
> {code}
> - Make protected class as private;
> {code}
> protected static class UseLimitException extends Exception
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)