You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/29 12:33:21 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #10359:
[FLINK-14813][metrics] Provide `isBackPressured` Task metric
pnowojski commented on a change in pull request #10359: [FLINK-14813][metrics] Provide `isBackPressured` Task metric
URL: https://github.com/apache/flink/pull/10359#discussion_r352113058
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -351,6 +353,7 @@ public Task(
this.taskManagerConfig = Preconditions.checkNotNull(taskManagerConfig);
this.metrics = metricGroup;
+ metricGroup.gauge(MetricNames.IS_BACKPRESSURED, new BackPressureGauge(this));
Review comment:
I'm not sure what "0.3" of back pressure should mean? Task is back pressured, or it's not. Unless 0.3 would mean that task is back pressured 30% of the time? But such kind of aggregation maybe should be performed on some upper level (if at all).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services