You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/13 08:04:47 UTC

[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12070: [TIR][Schedule] Refactor Tensorize

junrushao1994 commented on code in PR #12070:
URL: https://github.com/apache/tvm/pull/12070#discussion_r919774709


##########
tests/python/unittest/test_tir_schedule_blockize.py:
##########
@@ -15,12 +15,10 @@
 # specific language governing permissions and limitations

Review Comment:
   We can pass the original tests without any problem.
   
   However, I very much dislike the original way to write untitests that are not "unit" enough. For example, in principle, the tests for `Schedule.blockize` should never include invocation to other primitives, which would make them "composite" rather than "unit". I got it refactored for this reason.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org