You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 08:20:02 UTC
[GitHub] [airflow] potiuk opened a new pull request #16580: Exclude yarn.lock from the whl file
potiuk opened a new pull request #16580:
URL: https://github.com/apache/airflow/pull/16580
Currently the airflow wheel is built with the yarn.lock which
is not actually used by the airflow itself. Having this file in the
docker image causes the clair and trivy scanners to fail.
The yarn.lock however is needed in sdist package that's why it should
not be excluded via MANIFEST.in
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16580: Exclude yarn.lock from the whl file
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16580:
URL: https://github.com/apache/airflow/pull/16580#issuecomment-865695658
Don't close a PR and re-open a new one please -- just leave a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #16580: Exclude yarn.lock from the whl file
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #16580:
URL: https://github.com/apache/airflow/pull/16580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16580: Exclude yarn.lock from the whl file
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16580:
URL: https://github.com/apache/airflow/pull/16580#issuecomment-865684669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16580: Exclude yarn.lock from the whl file
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16580:
URL: https://github.com/apache/airflow/pull/16580#issuecomment-865726017
Sorry again for closing the original PR, I just pushed my stuff after testing without too much thinking of it, and then closed the other one. Anyway I also added fix that should fix the PROD image building. Turned out the "asset compilation" step was not really needed (and not possible when we missed yarn.lock) when Airflow is installed from packages. Now wo only compile the assets when airflow in prod image is built from sources (which is basically only when we use breeze to build it to test the latest version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16580: Exclude yarn.lock from the whl file
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16580:
URL: https://github.com/apache/airflow/pull/16580#issuecomment-865864016
I mixed sdist with source package. My bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org