You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/15 12:53:19 UTC
Review Request 21481: CLOUDSTACK-6612: Resolved DB connection issue related
to passing correct password
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21481/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-6612
https://issues.apache.org/jira/browse/CLOUDSTACK-6612
Repository: cloudstack-git
Description
-------
The attribute "passwd" was wrongly accessed as "passd". That's why the password of the database would always be passed as None.
With this change, correct password from config will be passed to the database.
Diffs
-----
tools/marvin/marvin/cloudstackTestClient.py 72ce7d3
Diff: https://reviews.apache.org/r/21481/diff/
Testing
-------
Yes.
Ran the test case mentioned in the bug which uses DB connection and it passed.
Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 508.665s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 21481: CLOUDSTACK-6612: Resolved DB connection issue
related to passing correct password
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21481/#review43100
-----------------------------------------------------------
Commit 14968daeaa454f872a6271172041596c208ce3f1 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=14968da ]
CLOUDSTACK-6612: Resolved DB connection issue related to passing correct password
- ASF Subversion and Git Services
On May 15, 2014, 10:53 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21481/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 10:53 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-6612
> https://issues.apache.org/jira/browse/CLOUDSTACK-6612
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The attribute "passwd" was wrongly accessed as "passd". That's why the password of the database would always be passed as None.
> With this change, correct password from config will be passed to the database.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 72ce7d3
>
> Diff: https://reviews.apache.org/r/21481/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Ran the test case mentioned in the bug which uses DB connection and it passed.
>
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 508.665s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21481: CLOUDSTACK-6612: Resolved DB connection issue
related to passing correct password
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21481/#review43101
-----------------------------------------------------------
Commit 94a7dee395aca1fb323e702f480cf4e900e6988e in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=94a7dee ]
CLOUDSTACK-6612: Resolved DB connection issue related to passing correct password
- ASF Subversion and Git Services
On May 15, 2014, 10:53 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21481/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 10:53 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-6612
> https://issues.apache.org/jira/browse/CLOUDSTACK-6612
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The attribute "passwd" was wrongly accessed as "passd". That's why the password of the database would always be passed as None.
> With this change, correct password from config will be passed to the database.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackTestClient.py 72ce7d3
>
> Diff: https://reviews.apache.org/r/21481/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Ran the test case mentioned in the bug which uses DB connection and it passed.
>
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 508.665s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>