[GitHub] [hive] amansinha100 commented on a diff in pull request #4223: HIVE-27253: Support array type when query does not produce any rows

["amansinha100 (via GitHub)" <gi...@apache.org>]

amansinha100 commented on code in PR #4223:
URL: https://github.com/apache/hive/pull/4223#discussion_r1164211860


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java:
##########
@@ -218,6 +218,13 @@ private static ASTNode createNullField(RelDataType fieldType) {
       return mapCallNode.node();
     }
 
+    if (fieldType.getSqlTypeName() == SqlTypeName.ARRAY) {

Review Comment:
   What about other complex types .. STRUCT and MAP ? 
   e.g  create table t1 (c3 struct <name: string, age: int>);
          CREATE TABLE t2 (c1 int, c2 map<c2:string, c3:int>);
   A struct can also appear within an array but that might be handled by this code change. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org