You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/23 06:31:35 UTC
[GitHub] [skywalking] dmsolr commented on a change in pull request #3591:
feat: add support of mongodb v3.7.x or higher
dmsolr commented on a change in pull request #3591: feat: add support of mongodb v3.7.x or higher
URL: https://github.com/apache/skywalking/pull/3591#discussion_r337869095
##########
File path: apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v3/define/v30/MongoDBV30Instrumentation.java
##########
@@ -17,67 +17,86 @@
*/
-package org.apache.skywalking.apm.plugin.mongodb.v3.define;
+package org.apache.skywalking.apm.plugin.mongodb.v3.define.v30;
import net.bytebuddy.description.method.MethodDescription;
import net.bytebuddy.matcher.ElementMatcher;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.InstanceMethodsInterceptPoint;
import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassInstanceMethodsEnhancePluginDefine;
import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
import org.apache.skywalking.apm.agent.core.plugin.match.NameMatch;
-import org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint;
+import org.apache.skywalking.apm.plugin.mongodb.v3.interceptor.v30.MongoDBV30Interceptor;
Review comment:
I took a glance. I think this rename class as `org.apache.skywalking.apm.plugin.mongodb.v30.interceptor.MongoDBInterceptor` will be more clear. HDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services