[jira] [Commented] (YARN-1655) Add implementations to FairScheduler to support increase/decrease container resource

["Wilfred Spiegelenburg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897819#comment-16897819 ] 

Wilfred Spiegelenburg commented on YARN-1655:
---------------------------------------------

Thank you for the feedback [~snemeth], sorry that it took this long.

I have updated the patch and fixed all the remarks.
All except for 4 are straight forward simple changes. To fix 4 I did the following:
- make a new {{allocate}} method in the MockRM that takes no arguments and calls the real allocate with _nulls_
- updated the calls in the test code to use the new method and added a comment to what it does (i.e. process outstanding requests)
- split the other {{allocate}} call in the test code into two steps: a separate alloc of the request and a call to {{allocate}} on the app master

That should clear point 4 up.

 [^YARN-1655.004.patch] 

> Add implementations to FairScheduler to support increase/decrease container resource
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-1655
>                 URL: https://issues.apache.org/jira/browse/YARN-1655
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>         Attachments: YARN-1655.001.patch, YARN-1655.002.patch, YARN-1655.003.patch, YARN-1655.004.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org