You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/30 16:56:03 UTC
[GitHub] [pulsar] shiv4289 opened a new pull request #8173: [WIP] [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
shiv4289 opened a new pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8173: [WIP] [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-701914940
@shiv4289 overall looks good to me. @BewareMyPower can probably help you add the test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-713739890
@BewareMyPower It is not the CI problem. `build/retry.sh` is a script introduced recently. The GitHub workflows are using this file. But it seems that branch `schema-version` is based on the old branch which doesn't have the retry.sh file. I have re-based Shiv's branch to the latest master. Let's see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-705316593
This error (./build/retry.sh: No such file or directory) is seen in the log in every run after a successful build. Retries are not helping.
```
2020-10-06T05:47:01.5179092Z [100%] Built target main
2020-10-06T05:47:03.7971812Z ##[group]Run ./build/retry.sh pulsar-client-cpp/docker-tests.sh
2020-10-06T05:47:03.7972605Z [36;1m./build/retry.sh pulsar-client-cpp/docker-tests.sh[0m
2020-10-06T05:47:03.8200137Z shell: /bin/bash -e {0}
2020-10-06T05:47:03.8200403Z env:
2020-10-06T05:47:03.8200948Z JAVA_HOME_8.0.265_x64: /opt/hostedtoolcache/jdk/8.0.265/x64
2020-10-06T05:47:03.8201457Z JAVA_HOME: /opt/hostedtoolcache/jdk/8.0.265/x64
2020-10-06T05:47:03.8201954Z JAVA_HOME_8_0_265_X64: /opt/hostedtoolcache/jdk/8.0.265/x64
2020-10-06T05:47:03.8202371Z ##[endgroup]
2020-10-06T05:47:03.8287415Z /home/runner/work/_temp/bc84e325-9808-450b-afae-966a2d0cd8a7.sh: line 1: ./build/retry.sh: No such file or directory
2020-10-06T05:47:03.8294667Z ##[error]Process completed with exit code 127.
2020-10-06T05:47:03.8362423Z Post job cleanup.
2020-10-06T05:47:04.1905004Z Post job cleanup.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] skyrocknroll commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
skyrocknroll commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-713756630
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-704034342
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-702824902
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r513182186
##########
File path: pulsar-client-cpp/python/schema_test.py
##########
@@ -354,6 +354,32 @@ class Example(Record):
self.assertEqual(r2.__class__.__name__, 'Example')
self.assertEqual(r2, r)
+ def test_schema_version(self):
+ class Example(Record):
+ a = Integer()
+ b = Integer()
+
+ client = pulsar.Client(self.serviceUrl)
+ producer = client.create_producer(
+ 'my-avro-python-schema-version-topic',
+ schema=AvroSchema(Example))
+
+ consumer = client.subscribe('my-avro-python-schema-version-topic', 'sub-1',
+ schema=AvroSchema(Example))
+
+ r = Example(a=1, b=2)
+ producer.send(r)
+
+ msg = consumer.receive()
+
+ self.assertIsNotNone(msg.schema_version())
+
+ self.assertEqual(0, int.from_bytes(msg.schema_version().encode(), byteorder='big'))
Review comment:
`int.from_bytes` is a Python3 method, but CI environment use Python2 to test. You need to use another method to convert bytes to int.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-714114434
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai merged pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] migmit commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
migmit commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r672596775
##########
File path: pulsar-client-cpp/include/pulsar/c/message.h
##########
@@ -200,6 +200,12 @@ PULSAR_PUBLIC const char *pulsar_message_get_topic_name(pulsar_message_t *messag
PULSAR_PUBLIC int pulsar_message_get_redelivery_count(pulsar_message_t *message);
+PULSAR_PUBLIC int pulsar_message_has_schema_version(pulsar_message_t *message);
Review comment:
Am I correct that this (and other two) functions were never implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r513170599
##########
File path: pulsar-client-cpp/python/schema_test.py
##########
@@ -354,6 +354,32 @@ class Example(Record):
self.assertEqual(r2.__class__.__name__, 'Example')
self.assertEqual(r2, r)
+ def test_schema_version(self):
+ class Example(Record):
+ a = Integer()
+ b = Integer()
+
+ client = pulsar.Client(self.serviceUrl)
+ producer = client.create_producer(
+ 'my-avro-python-schema-version-topic',
+ schema=AvroSchema(Example))
+
+ r = Example(a=1, b=2)
+ producer.send(r)
+
+ consumer = client.subscribe('my-avro-python-schema-version-topic', 'sub-1',
+ schema=AvroSchema(Example))
Review comment:
Done, thanks for spotting that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r672757430
##########
File path: pulsar-client-cpp/include/pulsar/c/message.h
##########
@@ -200,6 +200,12 @@ PULSAR_PUBLIC const char *pulsar_message_get_topic_name(pulsar_message_t *messag
PULSAR_PUBLIC int pulsar_message_get_redelivery_count(pulsar_message_t *message);
+PULSAR_PUBLIC int pulsar_message_has_schema_version(pulsar_message_t *message);
Review comment:
Yeah, you can open a PR to add the missed implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] skyrocknroll commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
skyrocknroll commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-706255086
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r672757430
##########
File path: pulsar-client-cpp/include/pulsar/c/message.h
##########
@@ -200,6 +200,12 @@ PULSAR_PUBLIC const char *pulsar_message_get_topic_name(pulsar_message_t *messag
PULSAR_PUBLIC int pulsar_message_get_redelivery_count(pulsar_message_t *message);
+PULSAR_PUBLIC int pulsar_message_has_schema_version(pulsar_message_t *message);
Review comment:
Yeah, you can open a PR to add the missed implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-717740558
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8173: [WIP] [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-701884570
The cpp tests failed because your code was not well formatted. You should use `clang-format-5.0` to format code.
Also you could `git apply` following diff:
```diff
diff --git a/pulsar-client-cpp/include/pulsar/c/message.h b/pulsar-client-cpp/include/pulsar/c/message.h
index 8b4b612..f54d025 100644
--- a/pulsar-client-cpp/include/pulsar/c/message.h
+++ b/pulsar-client-cpp/include/pulsar/c/message.h
@@ -202,7 +202,7 @@ PULSAR_PUBLIC int pulsar_message_get_redelivery_count(pulsar_message_t *message)
PULSAR_PUBLIC int pulsar_message_has_schema_version(pulsar_message_t *message);
-PULSAR_PUBLIC const char* pulsar_message_get_schemaVersion(pulsar_message_t *message);
+PULSAR_PUBLIC const char *pulsar_message_get_schemaVersion(pulsar_message_t *message);
PULSAR_PUBLIC void pulsar_message_set_schema_version(pulsar_message_t *message, const char *schemaVersion);
diff --git a/pulsar-client-cpp/lib/MessageImpl.cc b/pulsar-client-cpp/lib/MessageImpl.cc
index 8acb959..5d1edbf 100644
--- a/pulsar-client-cpp/lib/MessageImpl.cc
+++ b/pulsar-client-cpp/lib/MessageImpl.cc
@@ -98,7 +98,7 @@ void MessageImpl::setRedeliveryCount(int count) { redeliveryCount_ = count; }
bool MessageImpl::hasSchemaVersion() const { return metadata.has_schema_version(); }
-void MessageImpl::setSchemaVersion(const std::string& schemaVersion) { schemaVersion_ = &schemaVersion; }
+void MessageImpl::setSchemaVersion(const std::string& schemaVersion) { schemaVersion_ = &schemaVersion; }
const std::string& MessageImpl::getSchemaVersion() const { return metadata.schema_version(); }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-713233326
@BewareMyPower @shiv4289 Can help check why ci fails, and make sure that we can merge in 2.6.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-702609298
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-713446114
@wolfstudy It's a rarely seen problem, each CI fails with the same reason:
> /home/runner/work/_temp/e35ee3c2-fd25-4719-bc75-efd7a38be497.sh: line 1: ./build/retry.sh: No such file or directory
It looks like the environment to run CI tests is totally broken. Rerun the CI makes no difference. The only solution I can think of is just close it and open a new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r512387016
##########
File path: pulsar-client-cpp/python/schema_test.py
##########
@@ -354,6 +354,32 @@ class Example(Record):
self.assertEqual(r2.__class__.__name__, 'Example')
self.assertEqual(r2, r)
+ def test_schema_version(self):
+ class Example(Record):
+ a = Integer()
+ b = Integer()
+
+ client = pulsar.Client(self.serviceUrl)
+ producer = client.create_producer(
+ 'my-avro-python-schema-version-topic',
+ schema=AvroSchema(Example))
+
+ r = Example(a=1, b=2)
+ producer.send(r)
+
+ consumer = client.subscribe('my-avro-python-schema-version-topic', 'sub-1',
+ schema=AvroSchema(Example))
Review comment:
We should call `subscribe` before `send` like what other unit tests do, otherwise the consumer will stuck at `receive`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on pull request #8173: [WIP] [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-702061919
>
> Also you could `git apply` following diff:
>
Applied the suggested diff and updated PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-715018172
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] skyrocknroll commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
skyrocknroll commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-717690014
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shiv4289 commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
shiv4289 commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r513193092
##########
File path: pulsar-client-cpp/python/schema_test.py
##########
@@ -354,6 +354,32 @@ class Example(Record):
self.assertEqual(r2.__class__.__name__, 'Example')
self.assertEqual(r2, r)
+ def test_schema_version(self):
+ class Example(Record):
+ a = Integer()
+ b = Integer()
+
+ client = pulsar.Client(self.serviceUrl)
+ producer = client.create_producer(
+ 'my-avro-python-schema-version-topic',
+ schema=AvroSchema(Example))
+
+ consumer = client.subscribe('my-avro-python-schema-version-topic', 'sub-1',
+ schema=AvroSchema(Example))
+
+ r = Example(a=1, b=2)
+ producer.send(r)
+
+ msg = consumer.receive()
+
+ self.assertIsNotNone(msg.schema_version())
+
+ self.assertEqual(0, int.from_bytes(msg.schema_version().encode(), byteorder='big'))
Review comment:
Fixed as suggested. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-703228607
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-717693651
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-702833776
I saw some unit tests failed by `./build/retry.sh: not found`. It looks like the `retry.sh` was somehow deleted. Could you give some help? @sijie @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] migmit commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
migmit commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r672596775
##########
File path: pulsar-client-cpp/include/pulsar/c/message.h
##########
@@ -200,6 +200,12 @@ PULSAR_PUBLIC const char *pulsar_message_get_topic_name(pulsar_message_t *messag
PULSAR_PUBLIC int pulsar_message_get_redelivery_count(pulsar_message_t *message);
+PULSAR_PUBLIC int pulsar_message_has_schema_version(pulsar_message_t *message);
Review comment:
Am I correct that this (and other two) functions were never implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r672757430
##########
File path: pulsar-client-cpp/include/pulsar/c/message.h
##########
@@ -200,6 +200,12 @@ PULSAR_PUBLIC const char *pulsar_message_get_topic_name(pulsar_message_t *messag
PULSAR_PUBLIC int pulsar_message_get_redelivery_count(pulsar_message_t *message);
+PULSAR_PUBLIC int pulsar_message_has_schema_version(pulsar_message_t *message);
Review comment:
Yeah, you can open a PR to add the missed implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] migmit commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
migmit commented on a change in pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#discussion_r672596775
##########
File path: pulsar-client-cpp/include/pulsar/c/message.h
##########
@@ -200,6 +200,12 @@ PULSAR_PUBLIC const char *pulsar_message_get_topic_name(pulsar_message_t *messag
PULSAR_PUBLIC int pulsar_message_get_redelivery_count(pulsar_message_t *message);
+PULSAR_PUBLIC int pulsar_message_has_schema_version(pulsar_message_t *message);
Review comment:
Am I correct that this (and other two) functions were never implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower removed a comment on pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message
Posted by GitBox <gi...@apache.org>.
BewareMyPower removed a comment on pull request #8173:
URL: https://github.com/apache/pulsar/pull/8173#issuecomment-717693651
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org