You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/11/28 08:13:56 UTC

Re: [PR] [SPARK-46124][CORE][SQL][SS][CONNECT][DSTREAM][MLLIB][ML][PYTHON][R][AVRO][K8S][YARN][UI] Replace explicit `ArrayOps#toSeq` with `s.c.immutable.ArraySeq.unsafeWrapArray` [spark]

LuciferYang commented on PR #44041:
URL: https://github.com/apache/spark/pull/44041#issuecomment-1829307492

   cc @srowen, could you help to review this pr if you have time. Thanks 
   
   Similar to https://github.com/apache/spark/pull/43666, the purpose of this pr is also to save a collection copy by using `immutable.ArraySeq.unsafeWrapArray `. This pr does not modify similar cases in the test code, and I do not plan to fix test code parts for the time being.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org