You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "InvisibleProgrammer (via GitHub)" <gi...@apache.org> on 2025/11/18 21:53:53 UTC
[PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
InvisibleProgrammer opened a new pull request, #6203:
URL: https://github.com/apache/hive/pull/6203
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "InvisibleProgrammer (via GitHub)" <gi...@apache.org>.
InvisibleProgrammer commented on code in PR #6203:
URL: https://github.com/apache/hive/pull/6203#discussion_r2550184922
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -72,12 +72,22 @@ static abstract class TestKeyIndexBuilder
}
void createTestAcidFile(Path path, int numRows, TestKeyIndexBuilder indexBuilder) throws Exception {
+ createTestAcidFile(path, numRows, indexBuilder, false);
+ }
+
+ void createTestAcidFile(Path path,
+ int numRows,
+ TestKeyIndexBuilder indexBuilder,
+ boolean acidMetadataLowerCase) throws Exception {
FileSystem fs = path.getFileSystem(conf);
fs.delete(path, true);
String typeStr = "struct<operation:int," +
"originalTransaction:bigint,bucket:int,rowId:bigint," +
"currentTransaction:bigint," +
"row:struct<a:int,b:struct<c:int>,d:string>>";
+ if (acidMetadataLowerCase) {
+ typeStr = typeStr.toLowerCase();
+ }
Review Comment:
Modified it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6203:
URL: https://github.com/apache/hive/pull/6203#issuecomment-3549806578
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6203) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6203&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6203&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6203&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6203&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6203&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6203)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "InvisibleProgrammer (via GitHub)" <gi...@apache.org>.
InvisibleProgrammer commented on PR #6203:
URL: https://github.com/apache/hive/pull/6203#issuecomment-3576225564
Double tested. We don't need to add extra dependencies.
```
export HADOOP_OPTS="-Dfs.defaultFS=file:///"
$HIVE_HOME/bin/hive --service fixacidkeyindex --recover /mypath/escalations/acidwrongorder/delta_0000001_0000003_v0000005/bucket_00000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6203:
URL: https://github.com/apache/hive/pull/6203#issuecomment-3552187284
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6203) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6203&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6203&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6203&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6203&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6203&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6203)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6203:
URL: https://github.com/apache/hive/pull/6203#issuecomment-3564732232
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6203) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6203&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6203&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6203&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6203&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6203&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6203)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz commented on code in PR #6203:
URL: https://github.com/apache/hive/pull/6203#discussion_r2555041302
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -219,6 +229,27 @@ public void testValidKeyIndex() throws Exception {
fixValidIndex(testFilePath);
}
+ @Test
+ public void testValidKeyIndexWithAcidMetadataLowerCase() throws Exception {
+ // Try with 0 row file.
+ createTestAcidFile(testFilePath, 0, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Try single stripe
+ createTestAcidFile(testFilePath, 100, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Multiple stripes
+ createTestAcidFile(testFilePath, 12000, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
Review Comment:
> My personal opinion is a single test case should contain only one assertion
We are on the same page then. :)
> But in that case, I wanted to choose an approach that matches with the existing code.
Ok
> Are you sure that I would do the split?
I was, but I don't want to block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "InvisibleProgrammer (via GitHub)" <gi...@apache.org>.
InvisibleProgrammer commented on code in PR #6203:
URL: https://github.com/apache/hive/pull/6203#discussion_r2542044852
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -72,12 +72,22 @@ static abstract class TestKeyIndexBuilder
}
void createTestAcidFile(Path path, int numRows, TestKeyIndexBuilder indexBuilder) throws Exception {
+ createTestAcidFile(path, numRows, indexBuilder, false);
+ }
+
+ void createTestAcidFile(Path path,
+ int numRows,
+ TestKeyIndexBuilder indexBuilder,
+ boolean acidMetadataLowerCase) throws Exception {
FileSystem fs = path.getFileSystem(conf);
fs.delete(path, true);
String typeStr = "struct<operation:int," +
"originalTransaction:bigint,bucket:int,rowId:bigint," +
"currentTransaction:bigint," +
"row:struct<a:int,b:struct<c:int>,d:string>>";
+ if (acidMetadataLowerCase) {
+ typeStr = typeStr.toLowerCase();
+ }
Review Comment:
It would give more control to the caller. And also, it would led to modifying the 4 already existing test cases.
Does it worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz merged PR #6203:
URL: https://github.com/apache/hive/pull/6203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "InvisibleProgrammer (via GitHub)" <gi...@apache.org>.
InvisibleProgrammer commented on PR #6203:
URL: https://github.com/apache/hive/pull/6203#issuecomment-3573963297
Please wait an additional day merging in - our downstream test had a result that I want to double-check: There is a chance that collections4 only comes as a transitive dependency, and our downstream cluster didn't find the collections4 jar file. I want to check if I need to add this as an explicit dependency to hive-exec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz commented on code in PR #6203:
URL: https://github.com/apache/hive/pull/6203#discussion_r2542001693
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -72,12 +72,22 @@ static abstract class TestKeyIndexBuilder
}
void createTestAcidFile(Path path, int numRows, TestKeyIndexBuilder indexBuilder) throws Exception {
+ createTestAcidFile(path, numRows, indexBuilder, false);
+ }
+
+ void createTestAcidFile(Path path,
+ int numRows,
+ TestKeyIndexBuilder indexBuilder,
+ boolean acidMetadataLowerCase) throws Exception {
FileSystem fs = path.getFileSystem(conf);
fs.delete(path, true);
String typeStr = "struct<operation:int," +
"originalTransaction:bigint,bucket:int,rowId:bigint," +
"currentTransaction:bigint," +
"row:struct<a:int,b:struct<c:int>,d:string>>";
+ if (acidMetadataLowerCase) {
+ typeStr = typeStr.toLowerCase();
+ }
Review Comment:
How about extracting `typeStr` to a constant and pass it as a parameter to `createTestAcidFile`. It would give more control to the caller.
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -219,6 +229,27 @@ public void testValidKeyIndex() throws Exception {
fixValidIndex(testFilePath);
}
+ @Test
+ public void testValidKeyIndexWithAcidMetadataLowerCase() throws Exception {
+ // Try with 0 row file.
+ createTestAcidFile(testFilePath, 0, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Try single stripe
+ createTestAcidFile(testFilePath, 100, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Multiple stripes
+ createTestAcidFile(testFilePath, 12000, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
Review Comment:
Could you please move these to new test methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29328: Orc acid footer metadata should be case insensitive [hive]
Posted by "InvisibleProgrammer (via GitHub)" <gi...@apache.org>.
InvisibleProgrammer commented on code in PR #6203:
URL: https://github.com/apache/hive/pull/6203#discussion_r2542061176
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -219,6 +229,27 @@ public void testValidKeyIndex() throws Exception {
fixValidIndex(testFilePath);
}
+ @Test
+ public void testValidKeyIndexWithAcidMetadataLowerCase() throws Exception {
+ // Try with 0 row file.
+ createTestAcidFile(testFilePath, 0, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Try single stripe
+ createTestAcidFile(testFilePath, 100, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Multiple stripes
+ createTestAcidFile(testFilePath, 12000, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
Review Comment:
I could. The question is: does it worth it?
It follows the exact same pattern as the other test cases.
If I separate for three test cases, it will lead to almost doubling the existing test cases in the class.
My personal opinion is a single test case should contain only one assertion, not multiple ones. But in that case, I wanted to choose an approach that matches with the existing code.
Are you sure that I would do the split?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org