You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/06/18 09:27:41 UTC
[GitHub] [incubator-celeborn] cxzl25 opened a new pull request, #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
cxzl25 opened a new pull request, #1601:
URL: https://github.com/apache/incubator-celeborn/pull/1601
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1601:
URL: https://github.com/apache/incubator-celeborn/pull/1601#issuecomment-1596437900
Thanks, merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1601:
URL: https://github.com/apache/incubator-celeborn/pull/1601#issuecomment-1596065357
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1601](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1601?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (811d41a) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/7d7107d607b853ab61b8299f83de2e3dacfa7e3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7d7107d) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
- Coverage 45.81% 45.78% -0.03%
==========================================
Files 159 159
Lines 9950 9950
Branches 970 970
==========================================
- Hits 4558 4555 -3
- Misses 5094 5097 +3
Partials 298 298
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1601/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
URL: https://github.com/apache/incubator-celeborn/pull/1601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #1601:
URL: https://github.com/apache/incubator-celeborn/pull/1601#issuecomment-1596083611
@zhongqiangczq pls take a look, if we need modify shuffleClient at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1601:
URL: https://github.com/apache/incubator-celeborn/pull/1601#discussion_r1233237449
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -991,7 +991,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
val (messageMaster, messageSlave) =
messageType match {
- case Type.PUSH_DATA | Type.PUSH_DATA_HAND_SHAKE =>
Review Comment:
duplicate match
https://github.com/apache/incubator-celeborn/blob/7d7107d607b853ab61b8299f83de2e3dacfa7e3c/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala#L994-L1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1601:
URL: https://github.com/apache/incubator-celeborn/pull/1601#discussion_r1233469843
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -991,7 +991,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
val (messageMaster, messageSlave) =
messageType match {
- case Type.PUSH_DATA | Type.PUSH_DATA_HAND_SHAKE =>
Review Comment:
ok, the duplicate match can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on pull request #1601: [CELEBORN-689] Fix the incorrect part of PushDataHandler message type converted to status code
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on PR #1601:
URL: https://github.com/apache/incubator-celeborn/pull/1601#issuecomment-1596415317
Now no need to care about this.
the message PUSH_DATA_HAND_SHAKE is used by flinkShuffleClient. Currently, flinkShuffleClient don't process this statuscode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org