You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/02/25 23:27:00 UTC
Review Request 18485: Improving sla_list_safe_domain performance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18485/
-----------------------------------------------------------
Review request for Aurora and Brian Wickman.
Bugs: AURORA-233
https://issues.apache.org/jira/browse/AURORA-233
Repository: aurora
Description
-------
- Replaced ACTIVE_STATES with a union of LIVE_STATES and STARTING.
- Changed _simulate_host_down to avoid constructing JobUpTimeSlaVector in order to calculate total tasks.
Before:
ncalls tottime percall cumtime percall
1 0.000 0.000 63.549 63.549
After:
ncalls tottime percall cumtime percall
1 0.000 0.000 44.857 44.857
Diffs
-----
src/main/python/apache/aurora/client/api/sla.py 4fcc07534dc3fb7a7c967c0b98ee8675123a56c7
src/test/python/apache/aurora/client/api/test_sla.py 4f0a2c07fbed975a43438f32b6a576e6b85da4f8
Diff: https://reviews.apache.org/r/18485/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/api:sla
Thanks,
Maxim Khutornenko
Re: Review Request 18485: Improving sla_list_safe_domain performance
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18485/#review35484
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Feb. 25, 2014, 10:26 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18485/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 10:26 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Bugs: AURORA-233
> https://issues.apache.org/jira/browse/AURORA-233
>
>
> Repository: aurora
>
>
> Description
> -------
>
> - Replaced ACTIVE_STATES with a union of LIVE_STATES and STARTING.
> - Changed _simulate_host_down to avoid constructing JobUpTimeSlaVector in order to calculate total tasks.
>
> Before:
> ncalls tottime percall cumtime percall
> 1 0.000 0.000 63.549 63.549
>
> After:
> ncalls tottime percall cumtime percall
> 1 0.000 0.000 44.857 44.857
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/sla.py 4fcc07534dc3fb7a7c967c0b98ee8675123a56c7
> src/test/python/apache/aurora/client/api/test_sla.py 4f0a2c07fbed975a43438f32b6a576e6b85da4f8
>
> Diff: https://reviews.apache.org/r/18485/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:sla
>
>
> Thanks,
>
> Maxim Khutornenko
>
>