[GitHub] [spark] srowen commented on a change in pull request #35879: [SPARK-38572][BUILD] Setting version to 3.4.0-SNAPSHOT

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #35879:
URL: https://github.com/apache/spark/pull/35879#discussion_r828343952



##########
File path: project/MimaExcludes.scala
##########
@@ -34,6 +34,10 @@ import com.typesafe.tools.mima.core.ProblemFilters._
  */
 object MimaExcludes {
 
+  // Exclude rules for 3.4.x
+  lazy val v34excludes = v33excludes ++ Seq(
+  )

Review comment:
       We should also remove old excludes at some point, and think we have at this stage previously? You could remove the v32excludes, as we no longer want to consider those breaking changes excluded from 3.3 -> 3.4. Same maybe for 3.3 even, but we can leave that




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org