You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sdap.apache.org by GitBox <gi...@apache.org> on 2021/10/25 23:02:07 UTC
[GitHub] [incubator-sdap-nexus] joshgarde opened a new pull request #140: SDAP-162 - Create build for nexus-webapp
joshgarde opened a new pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
Initial build pipeline work with GitHub Actions. Tested with forked repo: https://github.com/joshgarde/incubator-sdap-nexus/actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] joshgarde commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
joshgarde commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954970994
> I also wonder if we should document the new development process now that it has changed. For example, we have been opening PRs against the master branch, but I think now with your workflow we should open PRs against the develop branch
Perhaps this needs to be part of a larger documentation overhaul ticket? The current documentation seems to be outdated overall with where the project is right now
> Another thought -- what about the version in the openapi.yml file? It would be nice to version that automatically as well, though maybe that's a task for another time
That can be added to this ticket. It would just require a small change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
skorper commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955098723
Gotcha, makes sense thanks @joshgarde !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] joshgarde commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
joshgarde commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955095907
Now that I'm thinking more about it however, since the `openapi.yml` file remains static until an API update and it's not dynamically generated, perhaps it's better to keep that manually versioned so that we can properly follow semver semantics and document when breaking changes occur?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] ngachung merged pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
ngachung merged pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] joshgarde commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
joshgarde commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955062213
Yep - I was experimenting with a few solutions. The build's now passing - https://github.com/joshgarde/incubator-sdap-nexus/runs/4051377910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] joshgarde commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
joshgarde commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955098279
The commit of the versioning only occurs on `develop` and `master` branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] joshgarde commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
joshgarde commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955094503
Yes - the versioning for the openapi.yml now tracks the Docker version. The main version file in `docker/` gets bumped first and that version change gets reflected into the `openapi.yml`. I thought it would make sense to tie API spec versioning to the main nexus-webapp distribution, but it can be changed to track `analysis` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
skorper commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954209076
I also wonder if we should document the new development process now that it has changed. For example, we have been opening PRs against the master branch, but I think now with your workflow we should open PRs against the develop branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
skorper commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955040495
It looks like 88aa028 caused the build to break
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
skorper commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955095917
Does the version get bumped and committed back to openapi.yml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] ngachung merged pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
ngachung merged pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] ngachung merged pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
ngachung merged pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
skorper commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954963802
Another thought -- what about the version in the openapi.yml file? It would be nice to version that automatically as well, though maybe that's a task for another time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] joshgarde edited a comment on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
joshgarde edited a comment on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-954970994
> I also wonder if we should document the new development process now that it has changed. For example, we have been opening PRs against the master branch, but I think now with your workflow we should open PRs against the develop branch
Perhaps this needs to be part of a larger documentation overhaul ticket? The current documentation seems to be outdated overall with where the project is right now
> Another thought -- what about the version in the openapi.yml file? It would be nice to version that automatically as well, though maybe that's a task for another time
That can be added to this ticket. It would just require a small change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on a change in pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
skorper commented on a change in pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#discussion_r738644533
##########
File path: environment.yml
##########
@@ -0,0 +1,147 @@
+name: sdap-nexus
Review comment:
I assume we will need to re-generate this file regularly (similar to poetry.lock)? If so, maybe add something in the README about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on pull request #140: SDAP-162 - Create build for nexus-webapp
Posted by GitBox <gi...@apache.org>.
skorper commented on pull request #140:
URL: https://github.com/apache/incubator-sdap-nexus/pull/140#issuecomment-955084328
Can you explain how the versioning works now for the openapi.yml file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org