You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/02/08 00:12:51 UTC

[GitHub] sv2000 opened a new pull request #2549: GOBBLIN-678: Make flow.executionId available in the GaaS Flow config …

sv2000 opened a new pull request #2549: GOBBLIN-678: Make flow.executionId available in the GaaS Flow config …
URL: https://github.com/apache/incubator-gobblin/pull/2549
 
 
   …for use in job templates.
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-678
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   Job templates would like to reference flow.executionId in the job properties (e.g. to create tmp directories that use execution id as part of the directory path). Currently, for scheduled jobs, the flow execution id is not made available in the flow config.  
   
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   MultiHopFlowCompilerTest - changed job template to use flow.executionId and ensure the template is resolved during compilation.
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services