You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/03/16 19:06:44 UTC
[GitHub] [storm] nd368 opened a new pull request #3229: [STORM-2483]
misnamed parameters
nd368 opened a new pull request #3229: [STORM-2483] misnamed parameters
URL: https://github.com/apache/storm/pull/3229
all 15 usages of method were already sending in componentId as first argument, streamId as second argument - so only naming inside of method needed to be changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm edited a comment on issue #3229: [STORM-2483]
misnamed parameters
Posted by GitBox <gi...@apache.org>.
Ethanlm edited a comment on issue #3229: [STORM-2483] misnamed parameters
URL: https://github.com/apache/storm/pull/3229#issuecomment-600829826
Thanks. I believe 1.x-branch build is flaky. Rekicked it off again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm merged pull request #3229: [STORM-2483] misnamed
parameters
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3229: [STORM-2483] misnamed parameters
URL: https://github.com/apache/storm/pull/3229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on issue #3229: [STORM-2483] misnamed
parameters
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on issue #3229: [STORM-2483] misnamed parameters
URL: https://github.com/apache/storm/pull/3229#issuecomment-600829826
Thanks. I believe 1.x-branch build is flaky. Rekicked it again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] nd368 commented on issue #3229: [STORM-2483] misnamed
parameters
Posted by GitBox <gi...@apache.org>.
nd368 commented on issue #3229: [STORM-2483] misnamed parameters
URL: https://github.com/apache/storm/pull/3229#issuecomment-600819922
hi Ethan, have done so - how many travis CI checks need to pass for 1.x branch build to be considered successful? 🤔
https://github.com/apache/storm/pull/3230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services