You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/01/05 04:15:28 UTC
[GitHub] [hive] dengzhhu653 commented on a change in pull request #2852: HIVE-25783: Enforce ASF headers on Metastore
dengzhhu653 commented on a change in pull request #2852:
URL: https://github.com/apache/hive/pull/2852#discussion_r778534809
##########
File path: standalone-metastore/metastore-common/pom.xml
##########
@@ -530,84 +499,6 @@
</execution>
</executions>
</plugin>
- <plugin>
Review comment:
Same as above, we do not need integration test in `metastore-common`, maybe this plugin should be placed at `metastore-server`, which has aready been here.
##########
File path: standalone-metastore/metastore-common/pom.xml
##########
@@ -445,21 +436,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<executions>
- <execution>
Review comment:
`metastore-common` provides the common utils and apis for metastore, and we have only one test class in this module: [RetryTest](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/utils/RetryTest.java), this can be run without any requirements.
##########
File path: standalone-metastore/metastore-common/src/main/resources/datanucleus-log4j.properties
##########
@@ -1,17 +0,0 @@
-# Define the destination and format of our logging
-log4j.appender.A1=org.apache.log4j.FileAppender
Review comment:
Do not see any usage of this file in `metastore-common`, so removed...
##########
File path: standalone-metastore/metastore-server/pom.xml
##########
@@ -514,26 +514,6 @@
</execution>
</executions>
</plugin>
- <plugin>
Review comment:
There is no protobuf file in `metastore-server`, this should be in `metastore-common` instead
##########
File path: standalone-metastore/metastore-common/pom.xml
##########
@@ -404,15 +404,6 @@
</profiles>
<build>
- <resources>
Review comment:
No package.jdo file under the `metastore-common` directory
##########
File path: standalone-metastore/metastore-common/pom.xml
##########
@@ -640,22 +531,6 @@
</execution>
</executions>
</plugin>
- <plugin>
Review comment:
There is no need for antlr parsing the grammar file in `metastore-common`, perhaps we need it in `metastore-server` for parsing `Filter.g`: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g.
##########
File path: standalone-metastore/metastore-common/src/main/resources/metastore-site.xml
##########
@@ -1,34 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<?xml-stylesheet type="text/xsl" href="configuration.xsl"?><!--
Review comment:
Do not see any usage of this file in `metastore-common`, so removed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org