You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/23 22:12:53 UTC
[GitHub] [tomcat] larsgrefer opened a new pull request #284: Improve General IDE support
larsgrefer opened a new pull request #284:
URL: https://github.com/apache/tomcat/pull/284
see also: https://github.com/apache/tomcat/pull/282#pullrequestreview-399324287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] larsgrefer commented on a change in pull request #284: Improve General IDE support
Posted by GitBox <gi...@apache.org>.
larsgrefer commented on a change in pull request #284:
URL: https://github.com/apache/tomcat/pull/284#discussion_r418772613
##########
File path: .editorconfig
##########
@@ -0,0 +1,18 @@
+root = true
+
+[*]
+end_of_line = lf
+indent_style = space
+trim_trailing_whitespace = true
+
+[*.java]
+indent_size = 4
+max_line_length = 100
Review comment:
I took the numbers from here: https://github.com/apache/tomcat/blob/master/CONTRIBUTING.md#L127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on a change in pull request #284: Improve General IDE support
Posted by GitBox <gi...@apache.org>.
markt-asf commented on a change in pull request #284:
URL: https://github.com/apache/tomcat/pull/284#discussion_r418686412
##########
File path: .editorconfig
##########
@@ -0,0 +1,18 @@
+root = true
+
+[*]
+end_of_line = lf
+indent_style = space
+trim_trailing_whitespace = true
+
+[*.java]
+indent_size = 4
+max_line_length = 100
Review comment:
I think we have more to 120 for this.
##########
File path: .editorconfig
##########
@@ -0,0 +1,18 @@
+root = true
Review comment:
There probably needs to be some discussion on tge dev@ list whether or not we want to start using this. My own first impressions are positive.
##########
File path: .editorconfig
##########
@@ -0,0 +1,18 @@
+root = true
+
+[*]
+end_of_line = lf
+indent_style = space
+trim_trailing_whitespace = true
+
+[*.java]
+indent_size = 4
+max_line_length = 100
+ij_java_block_brace_style = end_of_line
+ij_java_else_on_new_line = false
+
+[*.{txt,md}]
+max_line_length = 80
+
+[*.xml]
+indent_size = 2
Review comment:
I'm not sure how consistent this is throughout the code base. I think the docs tend to use 2 but elsewhere it tends to be 4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #284: Improve General IDE support
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #284:
URL: https://github.com/apache/tomcat/pull/284#issuecomment-845012146
Thanks for this. I want to do a few checks locally and then I'll back-port it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf merged pull request #284: Improve General IDE support
Posted by GitBox <gi...@apache.org>.
markt-asf merged pull request #284:
URL: https://github.com/apache/tomcat/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] larsgrefer commented on a change in pull request #284: Improve General IDE support
Posted by GitBox <gi...@apache.org>.
larsgrefer commented on a change in pull request #284:
URL: https://github.com/apache/tomcat/pull/284#discussion_r418772805
##########
File path: .editorconfig
##########
@@ -0,0 +1,18 @@
+root = true
Review comment:
More information can be found here: https://editorconfig.org/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org