[jira] [Commented] (DRILL-2824) Function resolution should be deterministic

["Jinfeng Ni (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507326#comment-14507326 ] 

Jinfeng Ni commented on DRILL-2824:
-----------------------------------

+1.

Overall looks good to me. Two comments:
1).  can we put additional info into the log?  i.e put the following comment into log as well? 
+        // printing the possible matches

2). Is it possible to detect and log error, when we load the list of function implementation while drillbit starts, if there are more than 1 function implmentations having the same signature ( function name, parameter #, parameter number), yet other part is different (return type, null-handling policy etc)?

 

> Function resolution should be deterministic
> -------------------------------------------
>
>                 Key: DRILL-2824
>                 URL: https://issues.apache.org/jira/browse/DRILL-2824
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Mehant Baid
>            Assignee: Jinfeng Ni
>            Priority: Critical
>             Fix For: 1.0.0
>
>         Attachments: DRILL-2824.patch
>
>
> Currently as part of function resolution we cost all the possible function matches and pick the one with the best cost. However we simply pick the first one with the best cost, there may be a possibility that we have multiple functions that could have the same best cost and based on which function was first in the map we will execute different functions on different clusters. This JIRA aims to resolve functions in a deterministic way so we pick the same function consistently. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)