You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by adpg <gi...@git.apache.org> on 2015/06/11 13:09:53 UTC
[GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
GitHub user adpg opened a pull request:
https://github.com/apache/flex-sdk/pull/19
Update DateTimeFormatterEx.as
Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash when locale that uses a 24-hour setting.
Modification of public function getUse24HourFlag() of DateTimeFormatterEx.as to return a Boolean value instead of an Object value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adpg/flex-sdk adpg-FLEX-34581-patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flex-sdk/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 59ff4578920a45c68761fd4aa18f5421403c0cc6
Author: Ad Pijnenburg <pi...@riom.nl>
Date: 2015-06-11T10:27:27Z
Update DateTimeFormatterEx.as
Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash when locale that uses a 24-hour setting.
Updated public function getUse24HourFlag() of DateTimeFormatterEx.as to return a Boolean value instead of an Object value.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flex-sdk/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Fri, Jun 12, 2015 at 12:11 PM, Michael Schmalle <
teotigraphixllc@gmail.com> wrote:
> Is there any protocol on testing stuff, or does experience warrant
> understanding the side effects and making a decision based on your
> understanding?
>
At a minimum, a build, checkin test before commiting the code is
recommended. Hopefully the Mustella tests catch anything that is beyond
that.
And you are correct about understanding the side effects, etc. I am quite
familiar with the Mobile compnents/skins etc. so I am more confident about
this one than the other (ArrayList) patch.
Thanks,
Om
>
> Mike
>
> On Fri, Jun 12, 2015 at 3:08 PM, OmPrakash Muppirala <bigosmallm@gmail.com
> >
> wrote:
>
> > I think this is documented somewhere, but I will give it a go here.
> >
> > The github pull request usually has an url like:
> > https://github.com/apache/flex-sdk/pull/19
> >
> > You will just have to append a ".patch" to the end of the url like this:
> > https://github.com/apache/flex-sdk/pull/19.patch
> >
> > That would give you the patch file. You can download it and apply it as
> a
> > regular patch file in your local flex-sdk repo. Verify the changes and
> > commit/push. Pretty straightforward.
> >
> > In the commit message, adding the line "This closes #19" will trigger
> some
> > post-commit hook scripts that will cause the github pull request to be
> > closed automatically.
> >
> > Thanks,
> > Om
> >
> >
> > On Fri, Jun 12, 2015 at 11:58 AM, Michael Schmalle <
> > teotigraphixllc@gmail.com> wrote:
> >
> > > I'm playing stupid here but, how does a committer/PMC go about
> > fulfilling a
> > > pull request?
> > >
> > > Can you explain or point me to documentation?
> > >
> > > Mike
> > >
> > > On Fri, Jun 12, 2015 at 2:53 PM, OmPrakash Muppirala <
> > bigosmallm@gmail.com
> > > >
> > > wrote:
> > >
> > > > I'll take this one.
> > > >
> > > > Thanks,
> > > > Om
> > > >
> > > > On Fri, Jun 12, 2015 at 11:50 AM, Erik de Bruin <er...@ixsoftware.nl>
> > > > wrote:
> > > >
> > > > > Can someone please take a look a this?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > EdB
> > > > >
> > > > >
> > > > >
> > > > > On Thu, Jun 11, 2015 at 1:09 PM, adpg <gi...@git.apache.org> wrote:
> > > > >
> > > > > > GitHub user adpg opened a pull request:
> > > > > >
> > > > > > https://github.com/apache/flex-sdk/pull/19
> > > > > >
> > > > > > Update DateTimeFormatterEx.as
> > > > > >
> > > > > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner
> > > crash
> > > > > > when locale that uses a 24-hour setting.
> > > > > >
> > > > > > Modification of public function getUse24HourFlag() of
> > > > > > DateTimeFormatterEx.as to return a Boolean value instead of an
> > Object
> > > > > value.
> > > > > >
> > > > > > You can merge this pull request into a Git repository by running:
> > > > > >
> > > > > > $ git pull https://github.com/adpg/flex-sdk
> > > > adpg-FLEX-34581-patch-1
> > > > > >
> > > > > > Alternatively you can review and apply these changes as the patch
> > at:
> > > > > >
> > > > > > https://github.com/apache/flex-sdk/pull/19.patch
> > > > > >
> > > > > > To close this pull request, make a commit to your master/trunk
> > branch
> > > > > > with (at least) the following in the commit message:
> > > > > >
> > > > > > This closes #19
> > > > > >
> > > > > > ----
> > > > > > commit 59ff4578920a45c68761fd4aa18f5421403c0cc6
> > > > > > Author: Ad Pijnenburg <pi...@riom.nl>
> > > > > > Date: 2015-06-11T10:27:27Z
> > > > > >
> > > > > > Update DateTimeFormatterEx.as
> > > > > >
> > > > > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner
> > > crash
> > > > > > when locale that uses a 24-hour setting.
> > > > > >
> > > > > > Updated public function getUse24HourFlag() of
> > > > DateTimeFormatterEx.as
> > > > > > to return a Boolean value instead of an Object value.
> > > > > >
> > > > > > ----
> > > > > >
> > > > > >
> > > > > > ---
> > > > > > If your project is set up for it, you can reply to this email and
> > > have
> > > > > your
> > > > > > reply appear on GitHub as well. If your project does not have
> this
> > > > > feature
> > > > > > enabled and wishes so, or if the feature is enabled but not
> > working,
> > > > > please
> > > > > > contact infrastructure at infrastructure@apache.org or file a
> JIRA
> > > > > ticket
> > > > > > with INFRA.
> > > > > > ---
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Ix Multimedia Software
> > > > >
> > > > > Jan Luykenstraat 27
> > > > > 3521 VB Utrecht
> > > > >
> > > > > T. 06-51952295
> > > > > I. www.ixsoftware.nl
> > > > >
> > > >
> > >
> >
>
Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
Posted by Michael Schmalle <te...@gmail.com>.
Is there any protocol on testing stuff, or does experience warrant
understanding the side effects and making a decision based on your
understanding?
Mike
On Fri, Jun 12, 2015 at 3:08 PM, OmPrakash Muppirala <bi...@gmail.com>
wrote:
> I think this is documented somewhere, but I will give it a go here.
>
> The github pull request usually has an url like:
> https://github.com/apache/flex-sdk/pull/19
>
> You will just have to append a ".patch" to the end of the url like this:
> https://github.com/apache/flex-sdk/pull/19.patch
>
> That would give you the patch file. You can download it and apply it as a
> regular patch file in your local flex-sdk repo. Verify the changes and
> commit/push. Pretty straightforward.
>
> In the commit message, adding the line "This closes #19" will trigger some
> post-commit hook scripts that will cause the github pull request to be
> closed automatically.
>
> Thanks,
> Om
>
>
> On Fri, Jun 12, 2015 at 11:58 AM, Michael Schmalle <
> teotigraphixllc@gmail.com> wrote:
>
> > I'm playing stupid here but, how does a committer/PMC go about
> fulfilling a
> > pull request?
> >
> > Can you explain or point me to documentation?
> >
> > Mike
> >
> > On Fri, Jun 12, 2015 at 2:53 PM, OmPrakash Muppirala <
> bigosmallm@gmail.com
> > >
> > wrote:
> >
> > > I'll take this one.
> > >
> > > Thanks,
> > > Om
> > >
> > > On Fri, Jun 12, 2015 at 11:50 AM, Erik de Bruin <er...@ixsoftware.nl>
> > > wrote:
> > >
> > > > Can someone please take a look a this?
> > > >
> > > > Thanks,
> > > >
> > > > EdB
> > > >
> > > >
> > > >
> > > > On Thu, Jun 11, 2015 at 1:09 PM, adpg <gi...@git.apache.org> wrote:
> > > >
> > > > > GitHub user adpg opened a pull request:
> > > > >
> > > > > https://github.com/apache/flex-sdk/pull/19
> > > > >
> > > > > Update DateTimeFormatterEx.as
> > > > >
> > > > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner
> > crash
> > > > > when locale that uses a 24-hour setting.
> > > > >
> > > > > Modification of public function getUse24HourFlag() of
> > > > > DateTimeFormatterEx.as to return a Boolean value instead of an
> Object
> > > > value.
> > > > >
> > > > > You can merge this pull request into a Git repository by running:
> > > > >
> > > > > $ git pull https://github.com/adpg/flex-sdk
> > > adpg-FLEX-34581-patch-1
> > > > >
> > > > > Alternatively you can review and apply these changes as the patch
> at:
> > > > >
> > > > > https://github.com/apache/flex-sdk/pull/19.patch
> > > > >
> > > > > To close this pull request, make a commit to your master/trunk
> branch
> > > > > with (at least) the following in the commit message:
> > > > >
> > > > > This closes #19
> > > > >
> > > > > ----
> > > > > commit 59ff4578920a45c68761fd4aa18f5421403c0cc6
> > > > > Author: Ad Pijnenburg <pi...@riom.nl>
> > > > > Date: 2015-06-11T10:27:27Z
> > > > >
> > > > > Update DateTimeFormatterEx.as
> > > > >
> > > > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner
> > crash
> > > > > when locale that uses a 24-hour setting.
> > > > >
> > > > > Updated public function getUse24HourFlag() of
> > > DateTimeFormatterEx.as
> > > > > to return a Boolean value instead of an Object value.
> > > > >
> > > > > ----
> > > > >
> > > > >
> > > > > ---
> > > > > If your project is set up for it, you can reply to this email and
> > have
> > > > your
> > > > > reply appear on GitHub as well. If your project does not have this
> > > > feature
> > > > > enabled and wishes so, or if the feature is enabled but not
> working,
> > > > please
> > > > > contact infrastructure at infrastructure@apache.org or file a JIRA
> > > > ticket
> > > > > with INFRA.
> > > > > ---
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Ix Multimedia Software
> > > >
> > > > Jan Luykenstraat 27
> > > > 3521 VB Utrecht
> > > >
> > > > T. 06-51952295
> > > > I. www.ixsoftware.nl
> > > >
> > >
> >
>
Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I think this is documented somewhere, but I will give it a go here.
The github pull request usually has an url like:
https://github.com/apache/flex-sdk/pull/19
You will just have to append a ".patch" to the end of the url like this:
https://github.com/apache/flex-sdk/pull/19.patch
That would give you the patch file. You can download it and apply it as a
regular patch file in your local flex-sdk repo. Verify the changes and
commit/push. Pretty straightforward.
In the commit message, adding the line "This closes #19" will trigger some
post-commit hook scripts that will cause the github pull request to be
closed automatically.
Thanks,
Om
On Fri, Jun 12, 2015 at 11:58 AM, Michael Schmalle <
teotigraphixllc@gmail.com> wrote:
> I'm playing stupid here but, how does a committer/PMC go about fulfilling a
> pull request?
>
> Can you explain or point me to documentation?
>
> Mike
>
> On Fri, Jun 12, 2015 at 2:53 PM, OmPrakash Muppirala <bigosmallm@gmail.com
> >
> wrote:
>
> > I'll take this one.
> >
> > Thanks,
> > Om
> >
> > On Fri, Jun 12, 2015 at 11:50 AM, Erik de Bruin <er...@ixsoftware.nl>
> > wrote:
> >
> > > Can someone please take a look a this?
> > >
> > > Thanks,
> > >
> > > EdB
> > >
> > >
> > >
> > > On Thu, Jun 11, 2015 at 1:09 PM, adpg <gi...@git.apache.org> wrote:
> > >
> > > > GitHub user adpg opened a pull request:
> > > >
> > > > https://github.com/apache/flex-sdk/pull/19
> > > >
> > > > Update DateTimeFormatterEx.as
> > > >
> > > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner
> crash
> > > > when locale that uses a 24-hour setting.
> > > >
> > > > Modification of public function getUse24HourFlag() of
> > > > DateTimeFormatterEx.as to return a Boolean value instead of an Object
> > > value.
> > > >
> > > > You can merge this pull request into a Git repository by running:
> > > >
> > > > $ git pull https://github.com/adpg/flex-sdk
> > adpg-FLEX-34581-patch-1
> > > >
> > > > Alternatively you can review and apply these changes as the patch at:
> > > >
> > > > https://github.com/apache/flex-sdk/pull/19.patch
> > > >
> > > > To close this pull request, make a commit to your master/trunk branch
> > > > with (at least) the following in the commit message:
> > > >
> > > > This closes #19
> > > >
> > > > ----
> > > > commit 59ff4578920a45c68761fd4aa18f5421403c0cc6
> > > > Author: Ad Pijnenburg <pi...@riom.nl>
> > > > Date: 2015-06-11T10:27:27Z
> > > >
> > > > Update DateTimeFormatterEx.as
> > > >
> > > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner
> crash
> > > > when locale that uses a 24-hour setting.
> > > >
> > > > Updated public function getUse24HourFlag() of
> > DateTimeFormatterEx.as
> > > > to return a Boolean value instead of an Object value.
> > > >
> > > > ----
> > > >
> > > >
> > > > ---
> > > > If your project is set up for it, you can reply to this email and
> have
> > > your
> > > > reply appear on GitHub as well. If your project does not have this
> > > feature
> > > > enabled and wishes so, or if the feature is enabled but not working,
> > > please
> > > > contact infrastructure at infrastructure@apache.org or file a JIRA
> > > ticket
> > > > with INFRA.
> > > > ---
> > > >
> > >
> > >
> > >
> > > --
> > > Ix Multimedia Software
> > >
> > > Jan Luykenstraat 27
> > > 3521 VB Utrecht
> > >
> > > T. 06-51952295
> > > I. www.ixsoftware.nl
> > >
> >
>
Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
Posted by Michael Schmalle <te...@gmail.com>.
I'm playing stupid here but, how does a committer/PMC go about fulfilling a
pull request?
Can you explain or point me to documentation?
Mike
On Fri, Jun 12, 2015 at 2:53 PM, OmPrakash Muppirala <bi...@gmail.com>
wrote:
> I'll take this one.
>
> Thanks,
> Om
>
> On Fri, Jun 12, 2015 at 11:50 AM, Erik de Bruin <er...@ixsoftware.nl>
> wrote:
>
> > Can someone please take a look a this?
> >
> > Thanks,
> >
> > EdB
> >
> >
> >
> > On Thu, Jun 11, 2015 at 1:09 PM, adpg <gi...@git.apache.org> wrote:
> >
> > > GitHub user adpg opened a pull request:
> > >
> > > https://github.com/apache/flex-sdk/pull/19
> > >
> > > Update DateTimeFormatterEx.as
> > >
> > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash
> > > when locale that uses a 24-hour setting.
> > >
> > > Modification of public function getUse24HourFlag() of
> > > DateTimeFormatterEx.as to return a Boolean value instead of an Object
> > value.
> > >
> > > You can merge this pull request into a Git repository by running:
> > >
> > > $ git pull https://github.com/adpg/flex-sdk
> adpg-FLEX-34581-patch-1
> > >
> > > Alternatively you can review and apply these changes as the patch at:
> > >
> > > https://github.com/apache/flex-sdk/pull/19.patch
> > >
> > > To close this pull request, make a commit to your master/trunk branch
> > > with (at least) the following in the commit message:
> > >
> > > This closes #19
> > >
> > > ----
> > > commit 59ff4578920a45c68761fd4aa18f5421403c0cc6
> > > Author: Ad Pijnenburg <pi...@riom.nl>
> > > Date: 2015-06-11T10:27:27Z
> > >
> > > Update DateTimeFormatterEx.as
> > >
> > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash
> > > when locale that uses a 24-hour setting.
> > >
> > > Updated public function getUse24HourFlag() of
> DateTimeFormatterEx.as
> > > to return a Boolean value instead of an Object value.
> > >
> > > ----
> > >
> > >
> > > ---
> > > If your project is set up for it, you can reply to this email and have
> > your
> > > reply appear on GitHub as well. If your project does not have this
> > feature
> > > enabled and wishes so, or if the feature is enabled but not working,
> > please
> > > contact infrastructure at infrastructure@apache.org or file a JIRA
> > ticket
> > > with INFRA.
> > > ---
> > >
> >
> >
> >
> > --
> > Ix Multimedia Software
> >
> > Jan Luykenstraat 27
> > 3521 VB Utrecht
> >
> > T. 06-51952295
> > I. www.ixsoftware.nl
> >
>
Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I'll take this one.
Thanks,
Om
On Fri, Jun 12, 2015 at 11:50 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> Can someone please take a look a this?
>
> Thanks,
>
> EdB
>
>
>
> On Thu, Jun 11, 2015 at 1:09 PM, adpg <gi...@git.apache.org> wrote:
>
> > GitHub user adpg opened a pull request:
> >
> > https://github.com/apache/flex-sdk/pull/19
> >
> > Update DateTimeFormatterEx.as
> >
> > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash
> > when locale that uses a 24-hour setting.
> >
> > Modification of public function getUse24HourFlag() of
> > DateTimeFormatterEx.as to return a Boolean value instead of an Object
> value.
> >
> > You can merge this pull request into a Git repository by running:
> >
> > $ git pull https://github.com/adpg/flex-sdk adpg-FLEX-34581-patch-1
> >
> > Alternatively you can review and apply these changes as the patch at:
> >
> > https://github.com/apache/flex-sdk/pull/19.patch
> >
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> > This closes #19
> >
> > ----
> > commit 59ff4578920a45c68761fd4aa18f5421403c0cc6
> > Author: Ad Pijnenburg <pi...@riom.nl>
> > Date: 2015-06-11T10:27:27Z
> >
> > Update DateTimeFormatterEx.as
> >
> > Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash
> > when locale that uses a 24-hour setting.
> >
> > Updated public function getUse24HourFlag() of DateTimeFormatterEx.as
> > to return a Boolean value instead of an Object value.
> >
> > ----
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Can someone please take a look a this?
Thanks,
EdB
On Thu, Jun 11, 2015 at 1:09 PM, adpg <gi...@git.apache.org> wrote:
> GitHub user adpg opened a pull request:
>
> https://github.com/apache/flex-sdk/pull/19
>
> Update DateTimeFormatterEx.as
>
> Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash
> when locale that uses a 24-hour setting.
>
> Modification of public function getUse24HourFlag() of
> DateTimeFormatterEx.as to return a Boolean value instead of an Object value.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/adpg/flex-sdk adpg-FLEX-34581-patch-1
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/flex-sdk/pull/19.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #19
>
> ----
> commit 59ff4578920a45c68761fd4aa18f5421403c0cc6
> Author: Ad Pijnenburg <pi...@riom.nl>
> Date: 2015-06-11T10:27:27Z
>
> Update DateTimeFormatterEx.as
>
> Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash
> when locale that uses a 24-hour setting.
>
> Updated public function getUse24HourFlag() of DateTimeFormatterEx.as
> to return a Boolean value instead of an Object value.
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl