[GitHub] [james-project] quantranhong1999 commented on pull request #346: JAMES-3529 Validate version when set Filter

[GitBox <gi...@apache.org>]

quantranhong1999 commented on pull request #346:
URL: https://github.com/apache/james-project/pull/346#issuecomment-811801870


   @https://github.com/apache/james-project/pull/346/commits/72b265a2578314fa79786e46f6f8e1306e4f27e3
   I added an error message for easier handling exception (easily catch error message at filter/set).
   Why don't we just add an error message and every thing will be easier to handle? 
   for example: 
   ```
   Preconditions.checkArgument(shouldNotContainDuplicates(storeCommand.getRules()), "Contains duplicated rules");
   ```
   then when we call this API, we dont need to validate this again and just catch the error message no?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org