[GitHub] [arrow] nealrichardson commented on pull request #7805: ARROW-9528: [Python] Honor tzinfo when converting from datetime

[GitBox <gi...@apache.org>]

nealrichardson commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661323133


   Correct me if I'm wrong, but IIUC there are doubts about a few things:
   
   1) the correctness of the behavior on master (prior to reverting the initial change)
   2) the correctness of the behavior on this patch
   3) how much people have built expectations around the wrong behavior that is the status quo (0.17.1), in Spark and in general 
   4) how to give people a safe upgrade path that doesn't break production code, even if the changes are more "correct".
   
   This patch may be the right solution, but I fear that we haven't adequately thought through (and tested) all of the implications and upgrade paths. And two of the people with the strongest opinion's about pyarrow's API (@wesm and @pitrou) just left for vacation and have expressed a preference for reverting the initial change for the 1.0 release. At this stage of the 1.0 release, I'd rather pyarrow continue to be wrong in the expected way (i.e. revert and not merge this yet) than be right in an unexpected way and possibly wrong in other unknown ways.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org