You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/08 02:34:08 UTC

[GitHub] [flink] libenchao commented on a change in pull request #10745: [FLINK-15445][connectors/jdbc] JDBC Table Source didn't work for Type…

libenchao commented on a change in pull request #10745: [FLINK-15445][connectors/jdbc] JDBC Table Source didn't work for Type…
URL: https://github.com/apache/flink/pull/10745#discussion_r376680607
 
 

 ##########
 File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialect.java
 ##########
 @@ -35,6 +37,15 @@
 	 */
 	boolean canHandle(String url);
 
+	/**
+	 * Check if this dialect instance support a specific data type in table schema.
+	 *
+	 * @param schema the table schema
+	 */
+	default void validate(TableSchema schema) {
 
 Review comment:
   `ValidationException` is a `RuntimeException`, adding it to method signature won' t force caller the check it. Maybe we just need to add it in java doc like `LogicalTypeParser.parse` and `FieldInfoUtils.validateInputTypeInfo` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services