You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2012/08/17 01:45:37 UTC
[jira] [Created] (SLING-2563) when a thread pool is created without
a label, the label should be generated using the class name requesting the
thread pool
Justin Edelson created SLING-2563:
-------------------------------------
Summary: when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
Key: SLING-2563
URL: https://issues.apache.org/jira/browse/SLING-2563
Project: Sling
Issue Type: Improvement
Components: Commons
Reporter: Justin Edelson
"anonymous" thread pools are hard to troubleshoot, so we shouldn't allow them :)
If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2563) when a thread pool is created without
a label, the label should be generated using the class name requesting the
thread pool
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-2563:
----------------------------------
Attachment: SLING-2563.patch
proposed patch
> when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2563
> URL: https://issues.apache.org/jira/browse/SLING-2563
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Attachments: SLING-2563.patch
>
>
> "anonymous" thread pools are hard to troubleshoot, so we shouldn't allow them :)
> If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2563) when a thread pool is created
without a label, the label should be generated using the class name
requesting the thread pool
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-2563.
-----------------------------------
Resolution: Fixed
Fix Version/s: Commons Threads 3.2.0
Assignee: Justin Edelson
committed slightly modified patch in r1374422
> when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2563
> URL: https://issues.apache.org/jira/browse/SLING-2563
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Fix For: Commons Threads 3.2.0
>
> Attachments: SLING-2563.patch
>
>
> "anonymous" thread pools are hard to troubleshoot, so we shouldn't allow them :)
> If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2563) when a thread pool is created
without a label, the label should be generated using the class name
requesting the thread pool
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436593#comment-13436593 ]
Felix Meschberger commented on SLING-2563:
------------------------------------------
Basically sounds like a good idea.
I am a bit worried about the hard-coded and unchecked array indices. But probably the stack trace will always contain a lot more than just three elements.
> when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2563
> URL: https://issues.apache.org/jira/browse/SLING-2563
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Attachments: SLING-2563.patch
>
>
> "anonymous" thread pools are hard to troubleshoot, so we shouldn't allow them :)
> If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2563) when a thread pool is created
without a label, the label should be generated using the class name
requesting the thread pool
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436594#comment-13436594 ]
Carsten Ziegeler commented on SLING-2563:
-----------------------------------------
Actually we added ThreadPool#create(config, label) for this - but right, if this is not called or called without a value, it's hard to troubleshoot.
Can we add a length check to the array access, just to be sure?
> when a thread pool is created without a label, the label should be generated using the class name requesting the thread pool
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2563
> URL: https://issues.apache.org/jira/browse/SLING-2563
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Attachments: SLING-2563.patch
>
>
> "anonymous" thread pools are hard to troubleshoot, so we shouldn't allow them :)
> If a class com.myco.FooImpl calls ThreadPoolManager.create(config) then the resulting thread pool's name should contain com.myco.FooImpl
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira