You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/21 16:51:40 UTC
[GitHub] [nifi] nandorsoma opened a new pull request, #6230: NIFI-10260 Improve the display name and description of Validate DTD property
nandorsoma opened a new pull request, #6230:
URL: https://github.com/apache/nifi/pull/6230
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10260](https://issues.apache.org/jira/browse/NIFI-10260)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6230: NIFI-10260 Improve the display name and description of Validate DTD property
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6230: NIFI-10260 Improve the display name and description of Validate DTD property
URL: https://github.com/apache/nifi/pull/6230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6230: NIFI-10260 Improve the display name and description of Validate DTD property
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6230:
URL: https://github.com/apache/nifi/pull/6230#discussion_r926913425
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXPath.java:
##########
@@ -129,8 +129,10 @@ public class EvaluateXPath extends AbstractProcessor {
.build();
public static final PropertyDescriptor VALIDATE_DTD = new PropertyDescriptor.Builder()
+ .displayName("Allow Document Type Declaration")
Review Comment:
Recommend naming this `Allow DTD` to keep it similar to the previous name.
```suggestion
.displayName("Allow DTD")
```
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXPath.java:
##########
@@ -129,8 +129,10 @@ public class EvaluateXPath extends AbstractProcessor {
.build();
public static final PropertyDescriptor VALIDATE_DTD = new PropertyDescriptor.Builder()
+ .displayName("Allow Document Type Declaration")
.name("Validate DTD")
- .description("Specifies whether or not the XML content should be validated against the DTD.")
+ .description("When enabled, Embedded Document Type Declaration will be allowed and it will be used for the XML content validation. "
+ + "Because of security reasons it is advised to disable this feature.")
Review Comment:
Recommend adjusting the wording to clarify the security implications.
```suggestion
.description("Allow embedded Document Type Declaration in XML. "
+ "This feature should be disabled to avoid XML entity expansion vulnerabilities.")
```
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java:
##########
@@ -144,8 +144,10 @@ public class EvaluateXQuery extends AbstractProcessor {
.build();
public static final PropertyDescriptor VALIDATE_DTD = new PropertyDescriptor.Builder()
+ .displayName("Allow Document Type Declaration")
Review Comment:
```suggestion
.displayName("Allow DTD")
```
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java:
##########
@@ -144,8 +144,10 @@ public class EvaluateXQuery extends AbstractProcessor {
.build();
public static final PropertyDescriptor VALIDATE_DTD = new PropertyDescriptor.Builder()
+ .displayName("Allow Document Type Declaration")
.name("Validate DTD")
- .description("Specifies whether or not the XML content should be validated against the DTD.")
+ .description("When enabled, Embedded Document Type Declaration will be allowed and it will be used for the XML content validation. "
+ + "Because of security reasons it is advised to disable this feature.")
Review Comment:
```suggestion
.description("Allow embedded Document Type Declaration in XML. "
+ "This feature should be disabled to avoid XML entity expansion vulnerabilities.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #6230: NIFI-10260 Improve the display name and description of Validate DTD property
Posted by GitBox <gi...@apache.org>.
nandorsoma commented on PR #6230:
URL: https://github.com/apache/nifi/pull/6230#issuecomment-1191761818
> Thanks for the suggested improvements @nandorsoma!
>
> The clarification is helpful, I recommended some wording adjustments to clarify the security implications.
Thank you for the suggestions! I've accepted them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org