You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/04/28 07:42:41 UTC
[GitHub] [servicecomb-kie] GuoYL123 opened a new pull request #139: add total to health
GuoYL123 opened a new pull request #139:
URL: https://github.com/apache/servicecomb-kie/pull/139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #139: add total kv number to health
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #139:
URL: https://github.com/apache/servicecomb-kie/pull/139#discussion_r420530245
##########
File path: pkg/model/kv.go
##########
@@ -82,4 +82,5 @@ type DocHealthCheck struct {
Version string `json:"version"`
Revision string `json:"revision"`
Timestamp int64 `json:"timestamp"`
+ Total int64 `json:"total"`
Review comment:
这个用total_kv_count比较合适
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request #139: add total kv number to health
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #139:
URL: https://github.com/apache/servicecomb-kie/pull/139#discussion_r420572868
##########
File path: pkg/model/kv.go
##########
@@ -82,4 +82,5 @@ type DocHealthCheck struct {
Version string `json:"version"`
Revision string `json:"revision"`
Timestamp int64 `json:"timestamp"`
+ Total int64 `json:"total"`
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org