You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/01/16 06:59:10 UTC
[02/17] james-project git commit: MAILBOX-371 Remove unnecessary test
for lifecycle
MAILBOX-371 Remove unnecessary test for lifecycle
This test is in SingleLifeCycleTest, There is another equivalent test
with multiple event bus. Remove this because it is impossible to passed
when RabbitMQEventBusTest also implements MultipleLifeCycleTest, then in
setup phrase, two eventbus are up, that means, stopping one eventbus
doesn't make queue registration for key deleted. (Because there is another
eventbus is consuming this queue!)
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/7ce35a37
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/7ce35a37
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/7ce35a37
Branch: refs/heads/master
Commit: 7ce35a3784b7722392e6a12c4e021a08bfb9cfe6
Parents: 68735a2
Author: datph <dp...@linagora.com>
Authored: Mon Jan 14 11:02:44 2019 +0700
Committer: datph <dp...@linagora.com>
Committed: Wed Jan 16 05:38:45 2019 +0700
----------------------------------------------------------------------
.../apache/james/mailbox/events/RabbitMQEventBusTest.java | 9 ---------
1 file changed, 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/7ce35a37/mailbox/event/event-rabbitmq/src/test/java/org/apache/james/mailbox/events/RabbitMQEventBusTest.java
----------------------------------------------------------------------
diff --git a/mailbox/event/event-rabbitmq/src/test/java/org/apache/james/mailbox/events/RabbitMQEventBusTest.java b/mailbox/event/event-rabbitmq/src/test/java/org/apache/james/mailbox/events/RabbitMQEventBusTest.java
index 0daf7f0..efa8380 100644
--- a/mailbox/event/event-rabbitmq/src/test/java/org/apache/james/mailbox/events/RabbitMQEventBusTest.java
+++ b/mailbox/event/event-rabbitmq/src/test/java/org/apache/james/mailbox/events/RabbitMQEventBusTest.java
@@ -225,15 +225,6 @@ class RabbitMQEventBusTest implements GroupContract.SingleEventBusGroupContract,
}
@Test
- void stopShouldDeleteKeyRegistrationWorkQueue() {
- eventBus.start();
- eventBus.stop();
-
- assertThat(rabbitManagementAPI.listQueues())
- .isEmpty();
- }
-
- @Test
void eventBusShouldNotThrowWhenContinuouslyStartAndStop() {
assertThatCode(() -> {
eventBus.start();
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org