You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ugo Matrangolo (JIRA)" <ji...@apache.org> on 2007/07/04 22:47:04 UTC
[jira] Created: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
---------------------------------------------------------------
Key: DERBY-2900
URL: https://issues.apache.org/jira/browse/DERBY-2900
Project: Derby
Issue Type: Test
Reporter: Ugo Matrangolo
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2900) convert lang\bug5054, lang\bug4356
and lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo reassigned DERBY-2900:
-------------------------------------
Assignee: Ugo Matrangolo
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2900) convert lang\bug5054, lang\bug4356
and lang\bug5052rts to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520117 ]
Kathey Marsden commented on DERBY-2900:
---------------------------------------
I checked in this patch with a few minor changes. I reformatted the new files to have spaces instead of tabs. I added some comments based on the old bug information. I added in a couple of assertFullResultSet calls where it seemed appropriate. Hope these changes are ok.
Kathey
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_140807.txt, DERBY-2900_diff_180707.txt, DERBY-2900_stat_140807.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2900) convert lang\bug5054, lang\bug4356
and lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519710 ]
Ugo Matrangolo commented on DERBY-2900:
---------------------------------------
Hi Kathey.
Thank you for your review and sorry for the late reply.
I think I resolved all the issues you raised.
>Instead of
>while (rs.next()) {
>//System.out.println(rs.getString(1));
>}
>use JDBC.assertFullResultSet or JDBC.assertSingleValueResultSet to check the results.
I think that the meaning of this code is not to check the content of the result set: it wants only to consume all
the rows in the result.
>Statements created with createStatement() or prepareStatement() do not need to be closed. They will be >closed automatically.
Fixed.
>It would be good to have javadoc comments for the methods.
All javadoc from previous tests were borrowed in the actual code.
>For Bug5054 I think the contents of setUp can just be moved donw into the test method. testBugBug5054 >can be renamed with just one "Bug"
Fixed.
Please review,
--Ugo
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_180707.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2900) convert lang\bug5054, lang\bug4356
and lang\bug5052rts to JUnit
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510245 ]
Bryan Pendleton commented on DERBY-2900:
----------------------------------------
Generally, we prefer to retain the tests even after the bugs are fixed, as it helps to ensure that the bugs don't re-appear as we change the code in the future. Having a rich set of tests, even for problems that are long ago fixed, is a powerful aid to evolving the code in the future.
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2900) convert lang\bug5054, lang\bug4356
and lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510243 ]
Ugo Matrangolo commented on DERBY-2900:
---------------------------------------
Dear derby community,
I just converted these tests to JUnit but now I have some doubts.
As I can read from the code these tests are related to some bugs in the derby code that , I think, are now
fixed.
There is any reason to run these tests anymore ?? If the bugs were fixed we can simply delete them.
If I'm wrong I will post the converted tests asap.
Thank you for your attention,
--Ugo.
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2900:
----------------------------------
Attachment: DERBY-2900_stat_140807.txt
DERBY-2900_diff_140807.txt
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_140807.txt, DERBY-2900_diff_180707.txt, DERBY-2900_stat_140807.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2900) convert lang\bug5054, lang\bug4356
and lang\bug5052rts to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515880 ]
Kathey Marsden commented on DERBY-2900:
---------------------------------------
Thanks Ugo for converting these tests and sorry for the late review. Below are some comments.
In General:
There is a mixture of tabs and space indentation in new files. Please change to all spaces.
Instead of
while (rs.next()) {
//System.out.println(rs.getString(1));
}
use JDBC.assertFullResultSet or JDBC.assertSingleValueResultSet to check the results.
Statements created with createStatement() or prepareStatement() do not need to be closed. They will be closed automatically.
It would be good to have javadoc comments for the methods.
For Bug5054 I think the contents of setUp can just be moved donw into the test method. testBugBug5054 can be renamed with just one "Bug"
Thanks
Kathey
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_180707.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2900:
----------------------------------
Attachment: DERBY-2900_stat_180707.txt
DERBY-2900_diff_180707.txt
First draft of the coversion of these tests.
Please review,
--Ugo.
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_180707.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2900:
----------------------------------
Derby Info: [Patch Available]
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_140807.txt, DERBY-2900_diff_180707.txt, DERBY-2900_stat_140807.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo closed DERBY-2900.
---------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_140807.txt, DERBY-2900_diff_180707.txt, DERBY-2900_stat_140807.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2900:
----------------------------------
Derby Info: (was: [Patch Available])
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_180707.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2900:
----------------------------------
Derby Info: [Patch Available]
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_180707.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2900) convert lang\bug5054, lang\bug4356 and
lang\bug5052rts to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2900:
----------------------------------
Component/s: Test
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_140807.txt, DERBY-2900_diff_180707.txt, DERBY-2900_stat_140807.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.